metric: fix fileservice board

[reusee]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #16552

What this PR does / why we need it:

fix board definitions.

---

PR Type

Bug fix

---

Description

• Updated metric names in initFSIOMergerDurationRow and initFSReadDurationRow functions to ensure correct tracking of FileService durations.
• Changed mo_fs_io_merger_duration_seconds to mo_fs_io_merger_duration_seconds_bucket.
• Changed mo_fs_read_duration to mo_fs_read_duration_bucket.

---

Changes walkthrough 📝

	Relevant files
Bug fix	grafana_dashboard_fs.go Update metric names for FileService duration tracking        pkg/util/metric/v2/dashboard/grafana_dashboard_fs.go Updated metric names from mo_fs_io_merger_duration_seconds to mo_fs_io_merger_duration_seconds_bucket. Updated metric names from mo_fs_read_duration to mo_fs_read_duration_bucket. +15/-15

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and limited to renaming metrics in a specific file. The logic and structure of the code remain unchanged, making it easier to review.
🧪 Relevant tests	No
⚡ Possible issues	Metric Naming Consistency: Ensure that the new metric names (*_bucket) are consistent across all other files and configurations where these metrics are used or referenced.
🔒 Security concerns	No

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Remove the trailing space from the metric type get-entry-data to avoid inconsistencies Ensure that the metric type get-entry-data does not contain an unintended trailing space, which could lead to inconsistencies or bugs. pkg/util/metric/v2/dashboard/grafana_dashboard_fs.go [203] -c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="get-entry-data "`), +c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="get-entry-data"`), Suggestion importance[1-10]: 9 Why: This is a valid suggestion as the trailing space in the metric type string could lead to potential bugs or inconsistencies in metric filtering.	9
Possible issue	Add error handling for the c.getMetricWithFilter function calls to catch and handle any issues Consider adding error handling for the c.getMetricWithFilter function calls to ensure that any issues are caught and handled appropriately. pkg/util/metric/v2/dashboard/grafana_dashboard_fs.go [175-176] -c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="wait"`), -c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="initiate"`), +metricWait, err := c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="wait"`) +if err != nil { + return nil, err +} +metricInitiate, err := c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="initiate"`) +if err != nil { + return nil, err +} +c.getMultiHistogram( + []string{ + metricWait, + metricInitiate, + }, Suggestion importance[1-10]: 8 Why: Adding error handling is crucial for robustness, especially when dealing with external or dynamic data sources in metrics. This suggestion addresses a potential issue that could prevent silent failures.	8
Maintainability	Use a loop to iterate over metric types and append them to the slice to avoid repetitive code Consider using a loop to iterate over the metric types and append them to the slice, to avoid repetitive code and improve maintainability. pkg/util/metric/v2/dashboard/grafana_dashboard_fs.go [192-207] -c.getMultiHistogram( - []string{ - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="read-vector-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="update-vector-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="read-memory-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="update-memory-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="read-disk-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="update-disk-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="read-remote-cache"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="get-reader"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="get-content"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="get-entry-data "`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="write-to-writer"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="set-cached-data"`), - c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="disk-cache-set-file"`), - }, +metricTypes := []string{ + "read-vector-cache", "update-vector-cache", "read-memory-cache", "update-memory-cache", + "read-disk-cache", "update-disk-cache", "read-remote-cache", "get-reader", + "get-content", "get-entry-data ", "write-to-writer", "set-cached-data", "disk-cache-set-file", +} +metrics := make([]string, len(metricTypes)) +for i, metricType := range metricTypes { + metrics[i] = c.getMetricWithFilter(`mo_fs_read_duration_bucket`, `type="` + metricType + `"`) +} +c.getMultiHistogram(metrics, Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies repetitive code and offers a solution to improve maintainability by using a loop. This would make the code cleaner and easier to manage.	7
Best practice	Define a constant for the metric name and reuse it to improve readability To improve readability, consider defining a constant for the metric name mo_fs_io_merger_duration_seconds_bucket and reusing it in the function calls. pkg/util/metric/v2/dashboard/grafana_dashboard_fs.go [175-176] -c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="wait"`), -c.getMetricWithFilter(`mo_fs_io_merger_duration_seconds_bucket`, `type="initiate"`), +const metricName = `mo_fs_io_merger_duration_seconds_bucket` +c.getMetricWithFilter(metricName, `type="wait"`), +c.getMetricWithFilter(metricName, `type="initiate"`), Suggestion importance[1-10]: 6 Why: This suggestion promotes best practices by reducing redundancy and improving code readability, although it's not as critical as error handling or fixing potential bugs.	6