malloc: fix log level

[reusee]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue # https://github.com/matrixorigin/MO-Cloud/issues/3369

What this PR does / why we need it:

less verbose logging

---

PR Type

Enhancement

---

Description

• Adjusted the log level from Info to Debug in pkg/common/malloc/malloc.go to reduce verbosity in logging.

---

Changes walkthrough 📝

	Relevant files
Enhancement	malloc.go Adjust log level from `Info` to `Debug` in malloc.go          pkg/common/malloc/malloc.go Changed log level from Info to Debug for less verbose logging. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Review 🔍

⏱️ Estimated effort to review [1-5]	1, because the PR involves a simple one-line change in the logging level, which is straightforward to review.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Add a condition to check if debug logging is enabled to avoid unnecessary computation To avoid potential performance issues, consider wrapping the logging statement in a condition that checks if the debug level is enabled. This prevents unnecessary computation of log arguments when the debug level is not enabled. pkg/common/malloc/malloc.go [42-45] -logutil.Debug("malloc", - zap.Any("max buffer size", maxBufferSize), - zap.Any("num shards", numShards), - zap.Any("classes", len(classSizes)), +if logutil.IsDebugEnabled() { + logutil.Debug("malloc", + zap.Any("max buffer size", maxBufferSize), + zap.Any("num shards", numShards), + zap.Any("classes", len(classSizes)), + ) +} Suggestion importance[1-10]: 8 Why: This is a good suggestion for performance optimization, especially in production environments where debug logging might be turned off. It prevents unnecessary computation of log arguments.	8
Enhancement	Add conditional logging to log at different levels based on the value of n Consider adding a condition to log at different levels based on the value of n. For example, log at Debug level if n is below a certain threshold and at Info level otherwise. This will provide more granular logging and help in debugging. pkg/common/malloc/malloc.go [42-45] -logutil.Debug("malloc", - zap.Any("max buffer size", maxBufferSize), - zap.Any("num shards", numShards), - zap.Any("classes", len(classSizes)), +if n < threshold { + logutil.Debug("malloc", + zap.Any("max buffer size", maxBufferSize), + zap.Any("num shards", numShards), + zap.Any("classes", len(classSizes)), + ) +} else { + logutil.Info("malloc", + zap.Any("max buffer size", maxBufferSize), + zap.Any("num shards", numShards), + zap.Any("classes", len(classSizes)), + ) +} Suggestion importance[1-10]: 7 Why: This suggestion is valid as it introduces a dynamic logging level based on the value of n, which can be useful for more effective debugging. However, it's not crucial for functionality, hence the score.	7
Maintainability	Reduce log verbosity by removing unnecessary fields from the debug log Ensure that the zap.Any fields are necessary for debugging purposes. If some fields are not critical for debugging, consider removing them to reduce log verbosity. pkg/common/malloc/malloc.go [42-45] logutil.Debug("malloc", zap.Any("max buffer size", maxBufferSize), zap.Any("num shards", numShards), - zap.Any("classes", len(classSizes)), +) Suggestion importance[1-10]: 5 Why: While reducing log verbosity can help in maintaining cleaner logs, the suggestion does not provide evidence that the fields are indeed unnecessary. More context is needed to validate the removal of these fields.	5