fix 15848, cherry-pick #16435

[jiangxinmeng1]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #15848

What this PR does / why we need it:

Not set object created by CN as 1PC node

[matrix-meow]

@jiangxinmeng1 Thanks for your contributions!

Pull Request Review:

Title:

The title of the pull request is clear and concise, mentioning the fix number and cherry-pick reference.

Body:

The body of the pull request provides essential information about the type of PR (BUG fix), the specific issue it addresses (issue #15848), and a brief description of what the PR does. It would be beneficial to have a more detailed explanation of the issue and the reason for the change.

Changes:

1. In the table_space.go file, within the prepareApplyObjectStats function:
   • Line 250: The change modifies the CreateNonAppendableObject function call by setting the second argument to false instead of true.

Problems Identified:

1. Potential Bug Introduction:
   • The change made in the pull request modifies the argument passed to CreateNonAppendableObject from true to false. This alteration may have unintended consequences as it changes the behavior of object creation. It is crucial to ensure that this change does not introduce new bugs or issues related to object creation.

Suggestions for Improvement:

1. Clarify Intent:

   • It is recommended to provide a more detailed explanation in the pull request description about why the change from true to false is necessary. Understanding the rationale behind the modification can help reviewers and maintainers assess the impact of the change accurately.

2. Testing:

   • To mitigate the risk of introducing bugs, thorough testing should be conducted after making this change. Specifically, test cases related to object creation and functionality should be executed to ensure that the modification does not adversely affect the system.

3. Code Review:

   • A more comprehensive code review by team members familiar with the object creation logic can help identify any potential issues or improvements related to this change.

4. Documentation Update:

   • Update any relevant documentation or comments in the code to reflect the change made in the CreateNonAppendableObject function call. This will help future developers understand the reasoning behind the modification.

Overall Impression:

The pull request addresses a specific bug fix related to object creation in the table_space.go file. However, it is essential to ensure that the change does not introduce new issues and that the rationale behind the modification is well-documented for clarity. Conducting thorough testing and involving relevant team members in the review process can enhance the quality and reliability of the codebase.