-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] proxy: do not add to queue multi times when scaling CN #16388
Conversation
@volgariver6 Thanks for your contributions! Here are review comments for file pkg/proxy/rebalancer.go: Pull Request Review:Title and Body:The title and body of the pull request clearly indicate that it addresses a bug related to adding the same tunnel multiple times to a queue when scaling CN. The PR aims to refactor the code to prevent the same tunnel from being added to the queue before it finishes transferring and reset the transferred status back to false. The issue references are provided along with the explanation of the changes made. Changes in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Which issue(s) this PR fixes:
issue #16357 https://github.com/matrixorigin/MO-Cloud/issues/3323
What this PR does / why we need it:
refactor the code that do not allow the same tunnel in the queue
before the tunnel finished tranferring.
reset transferred back to false together with wg.Done.