change keep_user_target_list_in_result default to 1

[YANGGMM]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #15831

What this PR does / why we need it:

change keep_user_target_list_in_result default to 1

[matrix-meow]

@YANGGMM Thanks for your contributions!

Pull Request Review:

Title: change keep_user_target_list_in_result default to 1

Problem 1: Lack of Detailed Explanation

The title and body of the pull request lack a detailed explanation of why the change is necessary. It would be beneficial to provide more context on why the default value is being changed to 1 for keep_user_target_list_in_result. This information can help other team members understand the rationale behind the modification.

Problem 2: Security Concern - SQL Injection Vulnerability

In the tenant_upgrade_list.go file, the addition of upg_mo_mysql_compatibility_mode1 introduces a potential security risk due to the direct concatenation of SQL query in the UpgSql field. This can lead to SQL injection vulnerabilities. It is recommended to use parameterized queries or ORM methods to prevent SQL injection attacks.

Problem 3: Inconsistent Naming Convention

In the variables.go file, the variable keep_user_target_list_in_result is modified to have a default value of 1. However, the naming convention for this variable is not consistent with the existing variables in the file. It would be beneficial to ensure consistency in naming conventions across the codebase for better readability and maintainability.

Problem 4: Unnecessary Changes in Test Files

In the test files select_origin.result and select_origin.sql, there are changes made to set keep_user_target_list_in_result to 0. These changes seem unnecessary for the purpose of the pull request, which focuses on changing the default value to 1. It is recommended to avoid making unrelated changes in test files to maintain clarity and focus.

Optimization Suggestion:

• Provide a more detailed description in the pull request body to explain the rationale behind changing the default value.
• Refactor the SQL query in upg_mo_mysql_compatibility_mode1 to use parameterized queries to prevent SQL injection vulnerabilities.
• Ensure consistent naming conventions for variables in the codebase to improve readability.
• Avoid making unrelated changes in test files to keep the focus on the main purpose of the pull request.

By addressing the security concern, maintaining consistent naming conventions, and avoiding unnecessary changes, the pull request can be optimized for better code quality and security.

[qingxinhome]

需要往1.2-dev做cherry-pick