Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update calls to runtime.fastrand to use cheaprand for compatibility with Go 1.22 #14897

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

Aoang
Copy link
Contributor

@Aoang Aoang commented Mar 11, 2024

Update calls to runtime.fastrand to use cheaprand for compatibility with Go 1.22

In Golang 1.22, the runtime.fastrand method was renamed to cheaprand.
This commit updates all occurrences of runtime.fastrand in the project
to use the new cheaprand method to maintain compatibility with the latest
Golang version and address performance concerns.

Refer: https://gist.github.com/Aoang/3dc06f127f3f54507b7e06b7b6550c28

…ibility with Go 1.22

In Golang 1.22, the `runtime.fastrand` method was renamed to `cheaprand`.
This commit updates all occurrences of `runtime.fastrand` in the project
to use the new `cheaprand` method to maintain compatibility with the latest
Golang version and address performance concerns.

Refer: https://gist.github.com/Aoang/3dc06f127f3f54507b7e06b7b6550c28
@Aoang Aoang requested a review from XuPeng-SH as a code owner March 11, 2024 13:18
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Mar 11, 2024
@XuPeng-SH XuPeng-SH requested a review from reusee July 12, 2024 11:33
@sukki37 sukki37 merged commit 6816ea5 into matrixorigin:main Aug 8, 2024
14 of 18 checks passed
@Aoang Aoang deleted the fix/fastrand-go-122 branch August 9, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants