Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag 11334 #11513

Merged
merged 3 commits into from
Aug 29, 2023
Merged

add tag 11334 #11513

merged 3 commits into from
Aug 29, 2023

Conversation

Ariznawlll
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #

What this PR does / why we need it:

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Aug 29, 2023
@matrix-meow
Copy link
Contributor

@Ariznawlll Thanks for your contributions!

Title: add tag 11334

Body: The pull request is adding a tag with the number 11334. It does not specify the type of PR or the issue it fixes. The body is empty.

Changes:

  • In the file test/distributed/cases/pessimistic_transaction/transaction_enhance.sql, there is a change made on lines 173-175. The show create table atomic_table_13; line is added. Additionally, two new lines are added: -- @bvt:issue and -- @bvt:issue#11334. Finally, two lines are removed: drop table if exists atomic_table_12_5; and drop table if exists atomic_table_13;. A new table atomic_table_12_5 is created with two columns.

Problem 1: Lack of information in the title and body
The title and body of the pull request do not provide enough information about the purpose of the changes or the issue being addressed. It is important to clearly state the type of PR and the issue number it fixes in the body. This will help reviewers and future maintainers understand the context and purpose of the changes.

Suggestion 1: Provide more information in the title and body
The title should be more descriptive, such as "Fix issue #11334 by adding missing table creation statement". In the body, provide a brief explanation of what the PR does and why it is needed. Additionally, specify the type of PR and the issue number it fixes.

Problem 2: Inconsistent use of tags
The pull request adds two new tags, -- @bvt:issue and -- @bvt:issue#11334. However, it is not clear what these tags are for or how they should be used. There is no explanation or context provided.

Suggestion 2: Provide explanation and context for the tags
In the body of the pull request, explain the purpose and usage of the new tags. Provide examples or guidelines on how to use them correctly. This will help reviewers and future contributors understand the intention behind the tags and ensure consistent usage.

Optimization: Consolidate changes and provide a clear commit message
The changes made in the pull request involve adding a table creation statement and modifying some comments. These changes could be consolidated into a single commit with a clear commit message explaining the purpose of the changes. This will make it easier to track and understand the changes in the codebase.

Overall, the pull request needs more information in the title and body to provide context and explain the purpose of the changes. Additionally, the usage of the new tags should be clarified. Consolidating the changes into a single commit with a clear commit message would also improve the readability and maintainability of the codebase.

@mergify mergify bot merged commit 3b81305 into matrixorigin:main Aug 29, 2023
sukki37 pushed a commit that referenced this pull request Sep 9, 2023
sukki37 pushed a commit that referenced this pull request Sep 14, 2023
sukki37 pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants