Reuse Compile for prepare (#17647)

Reuse Compile for prepare Approved by: @badboynt1, @daviszhen
matrixorigin · Jul 23, 2024 · f3a1ec7 · f3a1ec7
1 parent dcf1332
commit f3a1ec7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/pkg/frontend/mysql_cmd_executor.go b/pkg/frontend/mysql_cmd_executor.go
@@ -1084,13 +1084,6 @@ func createPrepareStmt(
 			comp.Release()
 			comp = nil
 		}
-
-		// @xxx when refactor prepare finish, remove this code
-		if comp != nil {
-			comp.SetIsPrepare(false)
-			comp.Release()
-			comp = nil
-		}
 	}
 
 	prepareStmt := &PrepareStmt{

diff --git a/pkg/sql/compile/scope.go b/pkg/sql/compile/scope.go
@@ -202,6 +202,15 @@ func (s *Scope) Run(c *Compile) (err error) {
 	if s.DataSource.isConst {
 		_, err = p.ConstRun(s.DataSource.Bat, s.Proc)
 	} else {
+		if s.DataSource.R == nil {
+			s.NodeInfo.Data = s.NodeInfo.Data[:0]
+			readers, _, err := s.getReaders(c, 1)
+			if err != nil {
+				return err
+			}
+			s.DataSource.R = readers[0]
+		}
+
 		var tag int32
 		if s.DataSource.node != nil && len(s.DataSource.node.RecvMsgList) > 0 {
 			tag = s.DataSource.node.RecvMsgList[0].MsgTag