Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust-analyzer #3

Closed
wants to merge 1 commit into from

Conversation

ShadowJonathan
Copy link

@ShadowJonathan ShadowJonathan commented Dec 22, 2021

This patch fixes rust-analyzer on vscode, by temporarily patching the requirements to a commit version of ed25519-dalek

You can see the differences here: dalek-cryptography/ed25519-dalek@1.0.1...ad461f4

The following difference is what makes this patch workable;

-#![cfg(not(test))]
-#![forbid(unsafe_code)]
+#![cfg_attr(not(test), forbid(unsafe_code))]

From dalek-cryptography/ed25519-dalek#173;

Yes since this was added in 1.0.1, rust-analyzer is not happy since it compiles everything in test mode

This should be applied as long as ed25519-dalek 1.1 isn't out, or this crate has to be published to crates.io

@poljar
Copy link
Collaborator

poljar commented Dec 29, 2021

As discussed privately, this will have to wait for a ed25519-dalek release.

@ShadowJonathan
Copy link
Author

#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants