Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/do_request_json_for/do_request_json/ #955

Merged
merged 2 commits into from
Sep 16, 2020
Merged

s/do_request_json_for/do_request_json/ #955

merged 2 commits into from
Sep 16, 2020

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Sep 16, 2020 •
edited
Loading

Fixes #954

Fix an issue where /login would be provided a stale access token

@Half-Shot
s/do_request_json_for/do_request_json/
2289f3a 
Fix an issue where /login would be provided a stale access token
@Half-Shot Half-Shot mentioned this pull request Sep 16, 2020
Merged
anoadragon453
anoadragon453 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass.

@Half-Shot Half-Shot merged commit 77c9724 into develop Sep 16, 2020
@Half-Shot Half-Shot deleted the hs/dont-provide-at-for-login branch September 16, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"After changing password, can log in with new password" tries to login with an access_token
2 participants
@Half-Shot @anoadragon453