add test to ensure you can query devicelist of invited users. #462
Conversation
also add known broken test (commented out to stop it running and slowing things down using the new broken_test directive) to track matrix-org/synapse/#3503 - that we don't get device_list updates from invited users.
|
@richvdh if you can cast an opinion on this mess at some point it'd be appreciated. |
| local *multi_test = sub { _push_test( $filename, 1, @_ ); }; | ||
| local *test = sub { _push_test( $filename, 0, @_ ); }; | ||
| local *multi_test = sub { _push_test( $filename, 1, @_ ); }; | ||
| local *broken_test = sub {}; |
There was a problem hiding this comment.
well, if we're going to do this, then let's document what it's for, both here and in DEVELOP.rst. But I'm a bit unconvinced - the bug param means we'll expect it to fail, so why isn't that good enough?
There was a problem hiding this comment.
stick a timeout on sync_until_user_in_device_list if necessary.
| })->then( sub { | ||
| matrix_invite_user_to_room( $user1, $user2, $room_id ) | ||
| # })->then( sub { | ||
| # # KNOWN BROKEN: (https://github.com/matrix-org/synapse/issues/3503) |
There was a problem hiding this comment.
I don't really understand what you're doing here. If you just comment it out and run the query anyway, surely it is going to fail, because the update might not yet have propagated over federation?
| # })->then( sub { | ||
| # # KNOWN BROKEN: we should get an update from the invited user when they | ||
| # # update their devices, but we don't because of | ||
| # # https://github.com/matrix-org/synapse/issues/3504 |
There was a problem hiding this comment.
I can't see 3504 getting fixed for quite a while, since it will require some significant changes to the way invites work. Building even a failing test around assuming it will work seems a bit pointless.
|
Revisiting this 10 months later, I'm even more confused about what it is doing. AFAICT it is meant to be a repro test for matrix-org/synapse#3503, however without a fix for that on the horizon, I don't think the open PR is adding much value. If, at some point in the future, we get around to addressing matrix-org/synapse#3503, we can always resurrect this PR. |
also add known broken test (commented out to stop it running and slowing things down
using the new broken_test directive) to track matrix-org/synapse#3503 - that we
don't get device_list updates from invited users.