Add sqlite pusher_database to Homeserver Dendrite.pm #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
changed the title
richvdh
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
sorry, I'm not sure how this slipped through the net.
It looks sensible to me, though presumably we shouldn't merge it until matrix-org/dendrite#1842 is ready.
|
Thanks @richvdh, true no need to merge yet as we are refactoring the dendrite implementation :) |
|
@neilalexander I see you did a bunch of work on matrix-org/dendrite#1842. Could you have another quick look at this and check it is still relevant? |
|
@richvdh This is no longer needed since we refactored the push code to use the existing user API database instead, so will close. Thanks for flagging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Pusher Database as part of matrix-org/dendrite#1842 to resolve matrix-org/dendrite#611