Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove dead handled_events set in invite_join #9394

Merged
merged 2 commits into from
Feb 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9394.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove some dead code from the acceptance of room invites path.
6 changes: 0 additions & 6 deletions synapse/handlers/federation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1354,8 +1354,6 @@ async def do_invite_join(

await self._clean_room_for_join(room_id)

handled_events = set()

try:
# Try the host we successfully got a response to /make_join/
# request first.
Expand All @@ -1375,10 +1373,6 @@ async def do_invite_join(
auth_chain = ret["auth_chain"]
auth_chain.sort(key=lambda e: e.depth)

handled_events.update([s.event_id for s in state])
handled_events.update([a.event_id for a in auth_chain])
handled_events.add(event.event_id)

logger.debug("do_invite_join auth_chain: %s", auth_chain)
logger.debug("do_invite_join state: %s", state)

Expand Down