Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add an admin API for server media statistics #8723

Closed
wants to merge 3 commits into from

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Nov 5, 2020

Add GET /_synapse/admin/v1/statistics/server/media to get statisics about local media usage.
Related to #6094 and #8700

I am not sure if we should mark this API as draft.
Maybe is it better move to GET /_synapse/admin/v1/statistics/server or GET /_synapse/admin/v1/statistics and also add information like number of registered users.
Or should I am add number of registered users to this PR?

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

Signed-off-by: Dirk Klimpel [email protected]

@clokep clokep requested a review from a team November 11, 2020 14:17
@erikjohnston
Copy link
Member

This API doesn't strike me as super useful as is; were you planning on extending it with extra information? I'm mostly thinking that if we are going to end up extending this then it'd be good to know what that would roughly look like up front so that we can make sure the APIs make sense up front 🙂

@clokep clokep removed the request for review from a team November 19, 2020 19:26
@clokep clokep added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Nov 19, 2020
@clokep
Copy link
Member

clokep commented Dec 10, 2020

@dklimpel Were you planning on making further changes to this / rethinking it?

@dklimpel dklimpel marked this pull request as draft December 11, 2020 07:46
@dklimpel
Copy link
Contributor Author

Yes, it is in progress. Other tasks have a higher priority at the moment.

@richvdh
Copy link
Member

richvdh commented Jun 2, 2021

@dklimpel I'm going to close the PR for now. We'd obviously be delighted to reopen it if/when you have time to pick it up again!

@richvdh richvdh closed this Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants