This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove a bunch of unused code from event creation #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/kill_event_reference_hashes
branch
2 times, most recently
from
964123f
to
27b58cb
Compare
... to make way for a new method which just returns the event ids
…room in create_new_client_event
richvdh
force-pushed
the
rav/kill_event_reference_hashes
branch
from
27b58cb
to
550b294
Compare
erikjohnston
approved these changes
Jan 6, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '1807db5e7': changelog Remove unused get_latest_event_ids_and_hashes_in_room Remove unused get_prev_events_and_hashes_for_room Remove unused hashes and depths from _update_membership params Remove unused hashes and depths from create_event params Remove unused hashes and depths from create_new_client_event params replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in create_new_client_event rename get_prev_events_for_room to get_prev_events_and_hashes_for_room
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #6574, we were carefully pulling the event hashes out of
event_reference_hashesand then throwing them away. We can simplify this. Sadly we can't kill off event_reference_hashes altogether because it turns out to be used elsewhere after all.This PR is a series of commits each of which stands alone.