This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Port some admin handlers to async/await #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
suggested changes
Dec 17, 2019
| @@ -119,8 +113,7 @@ def set_user_server_admin(self, user, admin): | |||
| """ | |||
| return self.store.set_server_admin(user, admin) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def export_user_data(self, user_id, writer): | |||
| async def export_user_data(self, user_id, writer): | |||
There was a problem hiding this comment.
this one looks like it's got a yield in admin_cmd.py
There was a problem hiding this comment.
Oh good point. Apparently even searching for function references correctly was too much for me on Tuesday
richvdh
approved these changes
Dec 19, 2019
48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '3d46124ad': Port some admin handlers to async/await (#6559)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.