-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add config to change the delay before sending a notification email #16696
Add config to change the delay before sending a notification email #16696
Conversation
73cb705
to
34f6ee6
Compare
I am having a look at the throttle mechanism. I think it doesn't really make sense to have a MIN inferior to the delay, so I am thinking about setting THROTTLE_START_MS equals to the delay. |
34f6ee6
to
75e47fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, but a couple small comments.
Co-authored-by: Patrick Cloke <[email protected]>
I've addressed the comments, and set |
We would also need some configuration nobs to tweak throttle max and throttle multiplier, but I was thinking about doing that in another PR. I can add that to this one if you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MatMaul!
Signed-off-by: Mathieu Velten [email protected]
Pull Request Checklist
(run the linters)