Always update retry_last_ts

[erikjohnston]

Follow on from #16156

I think by updating retry_last_ts we recover from the failure modes quicker (as we don't need to wait for the retry interval to ramp up?)

[MatMaul]

After more thinking, is the WHERE clause really needed at all ? set_destination_retry_timings is only called in 2 places, and it seems to me that it is checking stuffs that should always be valid.

[erikjohnston]

After more thinking, is the WHERE clause really needed at all ? set_destination_retry_timings is only called in 2 places, and it seems to me that it is checking stuffs that should always be valid.

I think the WHERE clause is mostly just there to help with the case where two workers are both trying to update the table at the same time. You're right that it might be easier to just remove it, but I'd want to investigate a little bit more before doing so.

[MatMaul]

Ah yes workers!