-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
@sumnerevans I'm going to remove the review request from this since you marked it as a draft; if you are still looking for a review please shout about what bits you're looking for a review of (or why it is in draft but you want a review). Thanks! 👍 |
@clokep I accidentally opened as a non-draft PR. And then the automatic reviewer adder functionality kicked in and I could not remove it. Sorry about that! |
Not an issue! If it doesn't kick in when un-drafting the PR just shout! 👍 |
298355c
to
a126708
Compare
Blocked by matrix-org/complement#638 |
5d31b44
to
b0617e3
Compare
f05bb89
to
19a7e14
Compare
a91a9bd
to
46ed200
Compare
Co-authored-by: Patrick Cloke <[email protected]>
Co-authored-by: Patrick Cloke <[email protected]>
Co-authored-by: Patrick Cloke <[email protected]>
With the last comment and updating the complement tests this is all passing for me locally again! 👍 I'm pretty certain it is good to merge. |
Signed-off-by: Sumner Evans <[email protected]>
Signed-off-by: Sumner Evans <[email protected]>
Signed-off-by: Sumner Evans <[email protected]>
Signed-off-by: Sumner Evans <[email protected]>
Kicked off a new round of complement tests: https://github.com/matrix-org/synapse/actions/runs/6867273574 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good if the test run works. 🎉
Complement with workers was failing, hopefully the latest change fixes it: https://github.com/matrix-org/synapse/actions/runs/6877944714 |
Tests passed minus a known flake (matrix-org/sytest#1201). 🎉 Thanks for working through this with me! 🚀 |
Implements the recently merged MSC2246 Asynchronous Uploads for Synapse's media repository.
Closes #12484
POST /_matrix/media/v1/create
PUT /_matrix/media/v3/upload/{serverName}/{mediaId}
timeout_ms
support on/download
timeout_ms
support on/thumbnail
Signed-off-by: Sumner Evans [email protected]
Keywords: async
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)