Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Check appservice user interest against the local users instead of all users (get_users_in_room mis-use) #13958

Merged
merged 23 commits into from
Oct 27, 2022
Merged

Check appservice user interest against the local users instead of all users (get_users_in_room mis-use) #13958

merged 23 commits into from
Oct 27, 2022

Commits on Sep 29, 2022

  1. Check appservice user interest against the local users instead of all… 

    … users

`get_local_users_in_room` is way more performant since it looks at a single
table (`local_current_membership`) and is looking through way less
data since it only worries about the local users in the room instead
of everyone in the room across the federation.

Fix #13942

Related to:

 - #13605
 - #13608
 - #13606
    @MadLittleMods
    MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    99a623d View commit details
    Browse the repository at this point in the history

  2. Remove non-appservice usages split out to other PRs

    @MadLittleMods
    MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    806b255 View commit details
    Browse the repository at this point in the history

  3. Add changelog

    @MadLittleMods
    MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    5f0f815 View commit details
    Browse the repository at this point in the history

  4. Revert back to using our own _matches_user_in_member_list thing 

    See #13958 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    a8be41b View commit details
    Browse the repository at this point in the history

  5. Rename variables to 'local' to be obvious our intention

    @MadLittleMods
    MadLittleMods committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    72985df View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Fix tests

    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    92b9da2 View commit details
    Browse the repository at this point in the history

  2. Wrapping happens at 88 chars 

    See #13958 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5d3c6a3 View commit details
    Browse the repository at this point in the history

  3. Add actual homeserver tests for local/remote interesting to appservic… 

    …e users

See #13958 (comment)
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    76435c7 View commit details
    Browse the repository at this point in the history

  4. Clarify interested/control and lints

    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    4451998 View commit details
    Browse the repository at this point in the history

  5. Revert mock

    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1218f03 View commit details
    Browse the repository at this point in the history

  6. Add test descriptions

    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7bd3803 View commit details
    Browse the repository at this point in the history

  7. Revert "Clarify interested/control and lints" 

    This reverts commit 4451998.
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    33f718c View commit details
    Browse the repository at this point in the history

  8. Revert "Add test descriptions" 

    This reverts commit 7bd3803.
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    cf8299b View commit details
    Browse the repository at this point in the history

  9. Revert "Revert mock" 

    This reverts commit 1218f03.
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    3de90e6 View commit details
    Browse the repository at this point in the history

  10. Revert "Add actual homeserver tests for local/remote interesting to a… 

    …ppservice users"

This reverts commit 76435c7.
    @MadLittleMods
    MadLittleMods committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    ab33cd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Move tests over from #14000 

    See #14000 (comment)
    @MadLittleMods
    MadLittleMods committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    3223512 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/13942-appservice-get_users_… 

    …in_room-mis-uses
    @MadLittleMods
    MadLittleMods committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d913ceb View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge branch 'develop' into madlittlemods/13942-appservice-get_users_… 

    …in_room-mis-uses
    @MadLittleMods
    MadLittleMods committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    4f29e75 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @MadLittleMods
    MadLittleMods committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    2665aa0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Add specific test to make sure local interesting user events are pick… 

    …ed up

See #13958 (review)
    @MadLittleMods
    MadLittleMods committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    39e2ead View commit details
    Browse the repository at this point in the history

  2. Update upgrade notes 

    See #13958 (comment)
    @MadLittleMods
    MadLittleMods committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    33a5b70 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. move comma

    @anoadragon453
    anoadragon453 authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    92400ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of github.com:matrix-org/synapse into madlittl… 

    …emods/13942-appservice-get_users_in_room-mis-uses
    @anoadragon453
    anoadragon453 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    426ef5c View commit details
    Browse the repository at this point in the history