Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve URL previews by not including the content of media tags in the generated description. #12887

Merged
merged 2 commits into from
May 26, 2022
Merged

Improve URL previews by not including the content of media tags in the generated description. #12887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7acdb
Strip svg, iframe, video and canvas elements as they usually don't ha…
reivilibre May 26, 2022
941a5f2
Newsfile
reivilibre May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12887.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve URL previews by not including the content of media tags in the generated description.
10 changes: 9 additions & 1 deletion synapse/rest/media/v1/preview_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ def parse_html_description(tree: "etree.Element") -> Optional[str]:

Grabs any text nodes which are inside the <body/> tag, unless they are within
an HTML5 semantic markup tag (<header/>, <nav/>, <aside/>, <footer/>), or
if they are within a <script/> or <style/> tag.
if they are within a <script/>, <svg/> or <style/> tag, or if they are within
a tag whose content is usually only shown to old browsers
(<iframe/>, <video/>, <canvas/>, <picture/>).

This is a very very very coarse approximation to a plain text render of the page.

Expand All @@ -268,6 +270,12 @@ def parse_html_description(tree: "etree.Element") -> Optional[str]:
"script",
"noscript",
"style",
"svg",
"iframe",
"video",
"canvas",
"img",
"picture",
etree.Comment,
)

Expand Down