Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Mark remote device list updates as already handled #12557

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Mark remote device list updates as already handled #12557

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd596d1
Mark remote device list updates as already handled
erikjohnston Apr 26, 2022
f563614
Newsfile
erikjohnston Apr 26, 2022
7493730
Fix tests
erikjohnston Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/storage/test_devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def add_device_change(self, user_id, device_ids, host):
for device_id in device_ids:
stream_id = self.get_success(
self.store.add_device_change_to_streams(
"user_id", [device_id], ["!some:room"]
user_id, [device_id], ["!some:room"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just plain broken before? (Why didn't we notice?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this unit test actually only cares about getting a stream_id out and inserting into add_device_list_outbound_pokes. TBH I'm not entirely convinced these unit tests are testing anything particular helpful, beyond basic "do my queries pull out what I just put into the DB?"

)
)

Expand Down