Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement cancellation support/protection for module callbacks #12469

Closed
wants to merge 3 commits into from
Closed

Implement cancellation support/protection for module callbacks #12469

wants to merge 3 commits into from

Commits on Apr 13, 2022

  1. Don't swallow CancelledErrors when running module callbacks 

    Update module callbacks with read semantics to not suppress
`CancelledError`s. Module callbacks with write semantics have been left
alone, since we don't expect cancellation to work correctly for those
code paths.

Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    7efb569 View commit details
    Browse the repository at this point in the history

  2. Protect module callbacks with read semantics against cancellation 

    The `on_*` callbacks have been left alone, since they are presumed to
be run on code paths that aren't cancellation-friendly.

Signed-off-by: Sean Quah <[email protected]>
    Sean Quah committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ad69b81 View commit details
    Browse the repository at this point in the history

  3. Add newsfile

    Sean Quah committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    84a47e3 View commit details
    Browse the repository at this point in the history