Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Recommend upgrading treq alongside twisted #11943

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Feb 8, 2022

See #11942 (this PR doesn't fix it but has more details on why this is necessary.

Updates the upgrade notes and changelog. I've already updated https://github.com/matrix-org/synapse/releases/tag/v1.52.0.

@babolivier babolivier requested a review from a team as a code owner February 8, 2022 16:54
@richvdh
Copy link
Member

richvdh commented Feb 8, 2022

doesn't fix #11942, since that is (on closer inspection) a problem with our debs, not pip

@babolivier
Copy link
Contributor Author

doesn't fix #11942, since that is (on closer inspection) a problem with our debs, not pip

Yep, I've updated the PR description, looks like we crossed streams here.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

changelog.d/11943.doc Outdated Show resolved Hide resolved
@babolivier babolivier enabled auto-merge (squash) February 9, 2022 14:45
@babolivier babolivier merged commit 6f440fd into master Feb 9, 2022
@babolivier babolivier deleted the babolivier/treq branch February 9, 2022 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants