-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commits on Dec 22, 2021
-
FederationClient.backfill
: stop flagging events as outliersEvents returned by `backfill` should not be flagged as outliers. Fixes: ``` AssertionError: null File "synapse/handlers/federation.py", line 313, in try_backfill dom, room_id, limit=100, extremities=extremities File "synapse/handlers/federation_event.py", line 517, in backfill await self._process_pulled_events(dest, events, backfilled=True) File "synapse/handlers/federation_event.py", line 642, in _process_pulled_events await self._process_pulled_event(origin, ev, backfilled=backfilled) File "synapse/handlers/federation_event.py", line 669, in _process_pulled_event assert not event.internal_metadata.is_outlier() ``` See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/231992 Fixes #8894.
Configuration menu - View commit details
-
Copy full SHA for 7bc58b9 - Browse repository at this point
Copy the full SHA 7bc58b9View commit details -
_auth_and_persist_outliers
: mark persisted events as outliersMark any events that get persisted via `_auth_and_persist_outliers` as, well, outliers. Currently this will be a no-op as everything will already be flagged as an outlier, but I'm going to change that.
Configuration menu - View commit details
-
Copy full SHA for 44fc789 - Browse repository at this point
Copy the full SHA 44fc789View commit details -
process_remote_join
: stop flagging as outlierThe events are now flagged as outliers later on, by `_auth_and_persist_outliers`.
Configuration menu - View commit details
-
Copy full SHA for 893eb7b - Browse repository at this point
Copy the full SHA 893eb7bView commit details -
send_join
: removeoutlier=True
The events created here are returned in the result of `send_join` to `FederationHandler.do_invite_join`. From there they are passed into `FederationEventHandler.process_remote_join`, which passes them to `_auth_and_persist_outliers`... which sets the `outlier` flag.
Configuration menu - View commit details
-
Copy full SHA for 49536a0 - Browse repository at this point
Copy the full SHA 49536a0View commit details -
get_event_auth
: removeoutlier=True
stop flagging the events returned by `get_event_auth` as outliers. This method is only called by `_get_remote_auth_chain_for_event`, which passes the results into `_auth_and_persist_outliers`, which will flag them as outliers.
Configuration menu - View commit details
-
Copy full SHA for 7a01a9c - Browse repository at this point
Copy the full SHA 7a01a9cView commit details -
_get_remote_auth_chain_for_event
: removeoutlier=True
we pass all the events into `_auth_and_persist_outliers`, which will now flag the events as outliers.
Configuration menu - View commit details
-
Copy full SHA for bca9f11 - Browse repository at this point
Copy the full SHA bca9f11View commit details -
_check_sigs_and_hash_and_fetch
: remove unusedoutlier
parameterThis param is now never set to True, so we can remove it.
Configuration menu - View commit details
-
Copy full SHA for 926cecb - Browse repository at this point
Copy the full SHA 926cecbView commit details -
_check_sigs_and_hash_and_fetch_one
: remove unusedoutlier
paramThis is no longer set anywhere, so we can remove it.
Configuration menu - View commit details
-
Copy full SHA for 220c163 - Browse repository at this point
Copy the full SHA 220c163View commit details -
get_pdu
: remove unusedoutlier
parameter... and chase it down into `get_pdu_from_destination_raw`.
Configuration menu - View commit details
-
Copy full SHA for b82366d - Browse repository at this point
Copy the full SHA b82366dView commit details -
event_from_pdu_json
: remove redundantoutlier
paramThis is never set to `True`, so can be removed.
Configuration menu - View commit details
-
Copy full SHA for 3f9d05f - Browse repository at this point
Copy the full SHA 3f9d05fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9564243 - Browse repository at this point
Copy the full SHA 9564243View commit details
Commits on Jan 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1275c7 - Browse repository at this point
Copy the full SHA f1275c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6417bd - Browse repository at this point
Copy the full SHA b6417bdView commit details