Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixed config parse bug in review_recent_signups #11191

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Fixed config parse bug in review_recent_signups #11191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71c9033
Fixed config parse bug in review_recent_signups
samuel-p Oct 27, 2021
a90f990
Create 11191.bugfix
samuel-p Oct 27, 2021
d71e2e2
Update changelog.d/11191.bugfix
samuel-p Oct 27, 2021
e447ffb
fixed imports
samuel-p Oct 27, 2021
5659fff
Merge remote-tracking branch 'origin/develop' into develop
samuel-p Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11191.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.45.0 which prevented the `synapse_review_recent_signups` script from running. Contributed by @samuel-p.
9 changes: 7 additions & 2 deletions synapse/_scripts/review_recent_signups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@

import attr

from synapse.config._base import RootConfig, find_config_files, read_config_files
from synapse.config._base import (
Config,
RootConfig,
find_config_files,
read_config_files,
)
from synapse.config.database import DatabaseConfig
from synapse.storage.database import DatabasePool, LoggingTransaction, make_conn
from synapse.storage.engines import create_engine
Expand Down Expand Up @@ -126,7 +131,7 @@ def main():
config_dict,
)

since_ms = time.time() * 1000 - config.parse_duration(config_args.since)
since_ms = time.time() * 1000 - Config.parse_duration(config_args.since)
exclude_users_with_email = config_args.exclude_emails
include_context = not config_args.only_users

Expand Down