Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix remove_stale_pushers job on SQLite. #10843

Merged
merged 6 commits into from
Sep 20, 2021
Merged

Fix remove_stale_pushers job on SQLite. #10843

merged 6 commits into from
Sep 20, 2021

Commits on Sep 17, 2021

  1. Fix the dishonest type annotations that allowed the bug 

    We iterate twice over the same Iterable, expecting it to be the
same size each time.
This is not valid; instead we should demand a Collection.
    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    1b5a33e View commit details
    Browse the repository at this point in the history

  2. Rename iterable to values and clarify docstring

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    683bb36 View commit details
    Browse the repository at this point in the history

  3. Fix additional type signatures

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    456e5e2 View commit details
    Browse the repository at this point in the history

  4. Fix the bug itself

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    1c4cf56 View commit details
    Browse the repository at this point in the history

  5. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    60b189a View commit details
    Browse the repository at this point in the history

  6. Update Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3a3565d View commit details
    Browse the repository at this point in the history