Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add an approximate difference method to StateFilters #10825

Merged
merged 35 commits into from
Oct 12, 2021
Merged

Add an approximate difference method to StateFilters #10825

merged 35 commits into from
Oct 12, 2021

Commits on Sep 15, 2021

  1. Add an approximate difference method to StateFilters

    @reivilibre
    reivilibre committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7dad902 View commit details
    Browse the repository at this point in the history

  2. Add tests for the approximate difference of StateFilters

    @reivilibre
    reivilibre committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    1fe75e6 View commit details
    Browse the repository at this point in the history

  3. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
    @reivilibre
    reivilibre committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    a05692c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Try to clarify docstring for approx_difference

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    10a7071 View commit details
    Browse the repository at this point in the history

  2. Process all the keys to return a narrower state filter

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    d0e14d5 View commit details
    Browse the repository at this point in the history

  3. Add more test cases

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    a5fdd46 View commit details
    Browse the repository at this point in the history

  4. STASH

    @reivilibre
    reivilibre committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    0e0085c View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Tighten up the postconditions of approx_difference 

    With thanks to David
    @reivilibre
    reivilibre committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9d50f05 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into rei/sf_diff

    @reivilibre
    reivilibre committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ace3316 View commit details
    Browse the repository at this point in the history

  3. More wordsmithing — thanks David

    @reivilibre
    reivilibre committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c72c436 View commit details
    Browse the repository at this point in the history

  4. Revert "STASH" 

    This reverts commit 0e0085c.
    @reivilibre
    reivilibre committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    bacd394 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Remove needless set construction

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    cd1de9b View commit details
    Browse the repository at this point in the history

  2. Simplify logic a bit, since this isn't operating in-place anyway

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    6bedcba View commit details
    Browse the repository at this point in the history

  3. Attempt to clean up approx_difference with improved comments and names

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    42617db View commit details
    Browse the repository at this point in the history

  4. Split out tests into own TestCase class

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    0c8e930 View commit details
    Browse the repository at this point in the history

  5. Add extensive tests for all 4 combinations of include_others

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b6274d6 View commit details
    Browse the repository at this point in the history

  6. Merge a test

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f6b4dc5 View commit details
    Browse the repository at this point in the history

  7. Split out some very simple tests

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    0d1c3d8 View commit details
    Browse the repository at this point in the history

  8. Deduplicate the old tests into the systematic style tests

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    18714d7 View commit details
    Browse the repository at this point in the history

  9. Add function to decompose a StateFilter into four parts

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    770afea View commit details
    Browse the repository at this point in the history

  10. Add StateFilter.freeze convenience constructor

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e119af9 View commit details
    Browse the repository at this point in the history

  11. Add recompose_from_four_parts method as inverse

    @reivilibre
    reivilibre committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    70f646a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Use a shorter version of decompose_into_four_parts.

    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    c9bb226 View commit details
    Browse the repository at this point in the history

  2. Use a shorter version of recompose_from_four_parts

    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    093f670 View commit details
    Browse the repository at this point in the history

  3. Use a step-by-step implementation of approx_difference rather than … 

    …splitting along types
    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    a187c24 View commit details
    Browse the repository at this point in the history

  4. Nest the ifs for clarity; no functional change

    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    4bbe3d1 View commit details
    Browse the repository at this point in the history

  5. Prefix decompose/recompose method names with underscores

    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    20bc299 View commit details
    Browse the repository at this point in the history

  6. Use self_excludes as it's equivalent with this definition of decompose

    @reivilibre
    reivilibre committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    27c3a7a View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Rename subtrahend to other to follow convention

    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    54d77c9 View commit details
    Browse the repository at this point in the history

  2. Try 'included' rather than 'admitted' to describe state filters 

    I don't think it's quite as good a fit but it might be more
approachable.
    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    538f99e View commit details
    Browse the repository at this point in the history

  3. Rename derived variables from sub(trahend) to other.

    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    bf202bc View commit details
    Browse the repository at this point in the history

  4. Add a little bit of context as to why this is useful

    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9169d38 View commit details
    Browse the repository at this point in the history

  5. Use 'returned' instead of 'resultant' as that may be clearer

    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    1f3008b View commit details
    Browse the repository at this point in the history

  6. Remove formal definition to focus on one way of explaining

    @reivilibre
    reivilibre committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3552bc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Use StateFilter.freeze in tests to improve readability

    @reivilibre
    reivilibre committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4eaf980 View commit details
    Browse the repository at this point in the history