Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Configuration manual lacks documentation for a bunch of workers settings #13643

Closed
richvdh opened this issue Aug 26, 2022 · 1 comment · Fixed by #14824
Closed

Configuration manual lacks documentation for a bunch of workers settings #13643

richvdh opened this issue Aug 26, 2022 · 1 comment · Fixed by #14824
Labels
A-Config Configuration, or the documentation thereof A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@richvdh
Copy link
Member

richvdh commented Aug 26, 2022 •
edited by DMRobertson
Loading

The following are all missing:

Update (dmr 2022-11-14): The following were missing, but then added in #14086:

  • Under "coordinating workers":
    • worker_replication_secret
    • start_pushers
    • pusher_instances
  • Under "individual worker configuration":
    • worker_app
    • worker_name
    • worker_replication_host
    • worker_replication_http_port
    • worker_listeners
    • worker_daemonize
    • worker_pid_file
    • worker_log_config
@richvdh richvdh added A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 26, 2022
@richvdh richvdh changed the title Configuration manual lacks documnetation for a bunch of workers settings Configuration manual lacks documentation for a bunch of workers settings Aug 28, 2022
@DMRobertson DMRobertson added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution A-Config Configuration, or the documentation thereof labels Aug 30, 2022
@dklimpel dklimpel mentioned this issue Oct 6, 2022
Merged
4 tasks
@dklimpel
Copy link
Contributor

Also missing:

  • update_user_directory_from_worker
  • notify_appservices_from_worker
  • media_instance_running_background_jobs

@dklimpel dklimpel mentioned this issue Dec 29, 2022
Merged
4 tasks
@dklimpel dklimpel mentioned this issue Jan 12, 2023
Merged
4 tasks
erikjohnston pushed a commit that referenced this issue Jan 13, 2023
@dklimpel
Add worker_manhole to configuration manual (#14824)
1caf16a 
Closes: #13643
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Config Configuration, or the documentation thereof A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add worker_manhole to configuration manual dklimpel/synapse_archive
3 participants
@richvdh @dklimpel @DMRobertson