Fix warnings about finish() after disconnect

matrix-org · Mar 23, 2020 · 6f36624 · 6f36624
1 parent b09dc68
commit 6f36624
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/84.bugfix b/changelog.d/84.bugfix
@@ -0,0 +1 @@
+Fix warnings about finish() after disconnect.
diff --git a/sygnal/http.py b/sygnal/http.py
@@ -240,7 +240,9 @@ async def _handle_dispatch(self, root_span, request, log, notif, context):
             request.setResponseCode(500)
             log.error("Exception whilst dispatching notification.", exc_info=True)
         finally:
-            request.finish()
+            if not request._disconnected:
+                request.finish()
+
             PUSHGATEWAY_HTTP_RESPONSES_COUNTER.labels(code=request.code).inc()
             root_span.set_tag(tags.HTTP_STATUS_CODE, request.code)