-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for blocking specific app/version/label combinations #85
Conversation
@@ -99,7 +99,7 @@ type issueBodyTemplatePayload struct { | |||
type genericWebhookPayload struct { | |||
payload | |||
// If a github/gitlab report is generated, this is set. | |||
ReportURL string `json:"report_url"` | |||
ReportURL string `json:"report_url"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking comment: any idea why this is happening? Has gofmt
changed the rules about struct formatting?I'm not convinced that the updated style is an improvement, but I don't care that much as long as we're not just going to flip-flop between the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why this is happening tbh. Empirically, this is what go fmt .
does, so it's not an IDE thing.
go version
go version go1.22.1 darwin/arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empirically, this is what
go fmt .
does,
same for me. weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tip.golang.org/doc/go1.19#go-doc are you on an old version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm saying that I'm on go1.22, and it does the same as you. It's entirely possible the current formatting came from an earlier version of go. Thanks for hunting down the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Richard van der Hoff <[email protected]>
No description provided.