This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Update Synapse pipelines for Python 3.9 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Callahan <[email protected]>
These stanzas have been commented out for more than a year Signed-off-by: Dan Callahan <[email protected]>
Weird contexts are more likely to uncover issues, test them first. Diff is a bit weird because of the reptition in the file, but this just moves the "noextras" stanza to immediately follow the "old deps" stanza. Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
Previously tested: - Python 3.5 w/ Postgres 9.5 - Python 3.7 w/ Postgres 11 - Python 3.8 w/ Postgres 12 Now tests: - Python 3.5 w/ Postgres 9.5 - Python 3.9 w/ Postgres 13 Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
Swaps the order of two entries to keep all Monolith and Worker stanzas grouped together, matching the order in the comment. Signed-off-by: Dan Callahan <[email protected]>
Avoids truncating and thus obscuring information in the Buildkite dashboard Signed-off-by: Dan Callahan <[email protected]>
richvdh
reviewed
Jan 7, 2021
Co-authored-by: Richard van der Hoff <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
|
I think this is good to go (note I've not actually tested this on Buildkite, since that's non-trivial, but there shouldn't be any risky changes.) |
richvdh
reviewed
Jan 8, 2021
| # 3. Python Version | ||
| # | ||
| # Tests can run against either a single or multiple PostgreSQL databases. |
There was a problem hiding this comment.
technically Synapse can run against a sqlite and a postgres, though doing that seems slightly insane and the sytest setup scripts have no support for such a thing.
richvdh
approved these changes
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Reviewable commit-by-commit.
This goes a bit further than a straight minimal update to Python 3.9; changes could be broken out separately if desired.
Specifically, I try to articulate what we're hoping to test in each section, then add / remove / re-order tests to align with that description.
I also re-named several tests to hopefully avoid truncating test names on the Buildkite dashboard, which I've found can obscure information, especially around the sytest and port_db suites.
If all goes well, we should have something like this:
Before:
After: