New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change flawed opt merge for Object.assign #37

Closed

f0x52 wants to merge 1 commit into matrix-org:master from f0x52:object-assign-opts

f0x52 commented Oct 13, 2019

This used to be an ad-hoc merge operation, which only works if your key already exists in the default options.
Object.assign() works way better


          change flawed opt merge for Object.assign

4c4dbff

Author

f0x52 commented Oct 13, 2019

seems this is somehow giving test errors. As this is part of a larger PR I'll just close this and wait till my tests pass :P

f0x52 closed this

f0x52 deleted the object-assign-opts branch

October 13, 2019 11:41

f0x52 restored the object-assign-opts branch

October 13, 2019 12:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet