Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle logMessage failing in ReportPoller timer #354

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jesopo
Copy link
Contributor

@jesopo jesopo commented Aug 15, 2022

I've left // failed to log. what do? scattered throughout this because i'd like to discuss what we should actually be doing, so this initial commit is just identifying problem areas.

my suggestion would be to actually put the try/catch in logMessage, and have it fallback to on-disk or off-premesis logging (grafana et al?)

@jesopo jesopo force-pushed the jess/report-polling-log-error branch from 0c65a0c to 83db5e2 Compare August 16, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant