Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on rate limit exceeded #456

Closed
FedericoCeratto opened this issue Dec 11, 2022 · 2 comments
Closed

Crash on rate limit exceeded #456

FedericoCeratto opened this issue Dec 11, 2022 · 2 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working, this is a bug

Comments

@FedericoCeratto
Copy link

Mjolnir 1.6.1 crashed out when hitting a rate limit:

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

There are cases when giving admin rights to Mjolnir is not possible or unwanted. Is in possible to have a form of throttling?
Thanks

Related to #27
@Yoric
Copy link
Contributor

Yoric commented Jan 12, 2023

Do you have the full error message?

Currently, Mjölnir retries throttled messages but does not retry timeouts. Is this one of these cases?

Yoric added a commit that referenced this issue Jan 12, 2023
@Yoric
Dealing with untrusted content - resolves #456
47a6a85
Yoric added a commit that referenced this issue Jan 12, 2023
@Yoric
Dealing with untrusted content - resolves #456
1345957
@H-Shay H-Shay added T-Defect Something isn't working, this is a bug S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jul 24, 2024
@turt2live
Copy link
Member

Closing due to lack of reply.

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working, this is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Yoric @FedericoCeratto @turt2live @H-Shay