Deprecate the sender_key and device_id on Megolm events
#1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSC: matrix-org/matrix-spec-proposals#3700 ([Markdown](https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3700-deprecate-sender-key.md)) The language around `m.room.encrypted` is a bit awkward because *technically* you can use the event to represent non-Megolm events, however that's considered an edge case at this time.
dkasak
reviewed
May 31, 2022
There was a problem hiding this comment.
Looks good overall! However I don't see a change here corresponding to this paragraph in MSC3700:
When clients receive an encrypted event with an unknown session they will need to send a key request to all clients, rather than the device specified by
sender_keyanddevice_id. This is the current behaviour used by Element clients.
and am failing to find an existing paragraph in the spec that mentions this.
nico-famedly
reviewed
Jun 1, 2022
|
@anoadragon453 please take another look |
anoadragon453
approved these changes
Jun 9, 2022
66 tasks
neilalexander
added a commit
to matrix-org/gomatrixserverlib
that referenced
this pull request
Aug 28, 2022
…epoints rather than bytes (matrix-org/matrix-spec#1101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC: matrix-org/matrix-spec-proposals#3700 (Markdown)
The language around
m.room.encryptedis a bit awkward because technically you can use the event to represent non-Megolm events, however that's considered an edge case at this time.Preview: https://pr1101--matrix-spec-previews.netlify.app