Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3828: Content Repository CORP Headers #3828

Merged
merged 9 commits into from
Jul 25, 2022
Merged

MSC3828: Content Repository CORP Headers #3828

merged 9 commits into from
Jul 25, 2022

Conversation

robertlong
Copy link
Contributor

@robertlong robertlong commented Jun 1, 2022 •
edited by richvdh
Loading

@robertlong robertlong changed the title Content Repository CORP Headers MSC3828: Content Repository CORP Headers Jun 1, 2022
@robertlong robertlong mentioned this pull request Jun 1, 2022
Merged
@uhoreg uhoreg added proposal A matrix spec change proposal client-server Client-Server API needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jun 1, 2022
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Jun 1, 2022
@ara4n ara4n removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 2, 2022
turt2live
turt2live approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once housekeeping is done I think this is ready for FCP.

proposals/3828-content-repository-corp-headers.md Outdated Show resolved Hide resolved
proposals/3828-content-repository-corp-headers.md Show resolved Hide resolved
robertlong
robertlong commented Jun 9, 2022
View reviewed changes
Copy link
Contributor Author

@robertlong robertlong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to submit this review. Still need some testing on chrome bug 1074261.

@turt2live
Copy link
Member

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 14, 2022 •
edited by dbkr
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 14, 2022
@turt2live turt2live mentioned this pull request Jun 14, 2022
Closed
@ShadowJonathan ShadowJonathan mentioned this pull request Jun 14, 2022
Closed
@mscbot
Copy link
Collaborator

mscbot commented Jul 19, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 19, 2022
@mscbot
Copy link
Collaborator

mscbot commented Jul 24, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 24, 2022
@anoadragon453 anoadragon453 merged commit d15a6a3 into matrix-org:main Jul 25, 2022
@anoadragon453 anoadragon453 added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 25, 2022
@turt2live turt2live self-assigned this Aug 2, 2022
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 2, 2022
@turt2live
Add CORP headers to media repo
bba7a41 
MSC: matrix-org/matrix-spec-proposals#3828
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 2, 2022
@turt2live
Add CORP headers to media repo
bd66aa1 
MSC: matrix-org/matrix-spec-proposals#3828
@turt2live turt2live mentioned this pull request Aug 2, 2022
Merged
@turt2live
Copy link
Member

spec PR: matrix-org/matrix-spec#1197

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Aug 2, 2022
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 9, 2022
@turt2live
Add CORP headers to media repo (#1197)
afc0e6a 
* Add CORP headers to media repo

MSC: matrix-org/matrix-spec-proposals#3828

* Write weird CSS rules to make added-in work inline in the CS spec

Even though our content doesn't need 2 paragraphs, it's good to have the capability to render it in the future.

* Remove test paragraph

* Refine prose

* spelling is key
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Aug 9, 2022
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
@zecakeh zecakeh mentioned this pull request Oct 2, 2022
Merged
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
14 tasks
@S7evinK S7evinK mentioned this pull request Jan 10, 2024
Merged
S7evinK added a commit to matrix-org/dendrite that referenced this pull request Jan 10, 2024
@S7evinK
Add CORP header to /download and /thumbnail (#3299)
e342420 
Part of #3222 

matrix-org/matrix-spec-proposals#3828
@S7evinK S7evinK mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NateTheGreatt NateTheGreatt NateTheGreatt left review comments

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live approved these changes

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@richvdh richvdh richvdh approved these changes

Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@robertlong @turt2live @mscbot @NateTheGreatt @uhoreg @anoadragon453 @richvdh @ShadowJonathan @ara4n