refactor(send queue): use a specialized mutex for locking access to the state store and being_sent
#4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4268 +/- ##
==========================================
- Coverage 85.03% 85.02% -0.01%
==========================================
Files 274 274
Lines 30028 30039 +11
==========================================
+ Hits 25533 25541 +8
- Misses 4495 4498 +3 ☔ View full report in Codecov by Sentry. |
…he state store and `being_sent` There was an implicit relationship that the `being_sent` lock needed to be taken in order to do non-atomic state store operations. With the change from this commit, the relationship is now more explicit: to get a handle to the state store, or being_sent, you have to obtain a `StoreLockGuard` by locking against the store itself. The `WeakClient` isn't stored in the QueueStorage data structure itself, so it's the only way to get a `dyn StateStore` from the `QueueStorage`.
bnjbvr
force-pushed
the
bnjbvr/being-sent-plus-store2
branch
from
473d03d
to
01ed8ad
Compare
Hywan
approved these changes
Nov 18, 2024
| @@ -1136,12 +1179,8 @@ impl QueueStorage { | |||
| file_media_request: MediaRequestParameters, | |||
| thumbnail: Option<(FinishUploadThumbnailInfo, MediaRequestParameters, Mime)>, | |||
| ) -> Result<(), RoomSendQueueStorageError> { | |||
| // Keep the lock until we're done touching the storage. | |||
| // TODO refactor to make the relationship between being_sent and the store more | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an implicit relationship that the
being_sentlock needed to be taken in order to do non-atomic state store operations. With the change from this commit, the relationship is now more explicit: to get a handle to the state store, or being_sent, you have to obtain aStoreLockGuardby locking against the store itself. TheWeakClientisn't stored in the QueueStorage data structure itself, so it's the only way to get adyn StateStorefrom theQueueStorage.