Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): Don't warn about verified users when subscribing to identity updates #4154

Draft
wants to merge 3 commits into
base: andybalaam/dont-emit-verified-identities-at-start-of-stream
Choose a base branch
from

Conversation

andybalaam
Copy link
Contributor

This is the Rust part of element-hq/element-meta#2492

and simplify them slightly by combining the wrapper with the main
function. The separation used to be needed, but is not any more.
@andybalaam andybalaam changed the base branch from main to andybalaam/dont-emit-verified-identities-at-start-of-stream October 18, 2024 14:51
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (f0fb72e) to head (c767363).

Files with missing lines Patch % Lines
...x-sdk-crypto/src/identities/room_identity_state.rs 85.71% 6 Missing ⚠️
Additional details and impacted files
@@                                       Coverage Diff                                       @@
##           andybalaam/dont-emit-verified-identities-at-start-of-stream    #4154      +/-   ##
===============================================================================================
- Coverage                                                        84.85%   84.84%   -0.02%     
===============================================================================================
  Files                                                              269      269              
  Lines                                                            28802    28822      +20     
===============================================================================================
+ Hits                                                             24439    24453      +14     
- Misses                                                            4363     4369       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant