bindings: Expose the PkEncryption stuff in the crypto crate bindings

[poljar]

Again a draft until we get things merged in vodozemac land.

@bmarty and @Velin92 I think this is all you need for the legacy apps. Please shout if there's more needed.

[bmarty]

@poljar I've got an issue when building this branch, not sure this is related to your change.

The command:

./scripts/build.sh -p ../matrix-rust-sdk -m crypto -t aarch64-linux-android

(from the project https://github.com/matrix-org/matrix-rust-components-kotlin)

and the error:

-- Generate uniffi files
-- library_path = /Users/bmarty/workspaces/matrix-rust-sdk/target/aarch64-linux-android/reldbg/libmatrix_sdk_crypto_ffi.so
Error: Constructor return type must be Self or Arc<Self>

any ideas?

[poljar]

@poljar I've got an issue when building this branch, not sure this is related to your change.

The command:

./scripts/build.sh -p ../matrix-rust-sdk -m crypto -t aarch64-linux-android

(from the project https://github.com/matrix-org/matrix-rust-components-kotlin)

and the error:

-- Generate uniffi files
-- library_path = /Users/bmarty/workspaces/matrix-rust-sdk/target/aarch64-linux-android/reldbg/libmatrix_sdk_crypto_ffi.so
Error: Constructor return type must be Self or Arc<Self>

any ideas?

Seems like I can't return Option<Arc<Self>> in the constructor, what I can return is Result<Arc<Self>>... Well OK, we'll add an error type.

[poljar]

@bmarty should work now, I changed the offending function to return an error instead.

[bmarty]

@bmarty should work now, I changed the offending function to return an error instead.

Thanks, it's now compiling.
/me does the next steps.

[bmarty]

OK, the code change is in this commit, you may want to double check: element-hq/element-android@355621b

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (3555474) to head (1fa5132).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3971   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         266      266           
  Lines       28286    28286           
=======================================
  Hits        23840    23840           
  Misses       4446     4446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

LGTM, there is a small typo in case you want to fix it.