Expose room_key_recipient_strategy through higher-level SDK crates
#3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and use it when sharing a room key.
... and pass it into the constructed BaseClient.
... and pass it through to the underlying ClientBuilder.
richvdh
force-pushed
the
rav/expose_collect_strategy
branch
from
709d35e
to
79e36ba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3864 +/- ##
=======================================
Coverage 84.09% 84.10%
=======================================
Files 261 261
Lines 27629 27638 +9
=======================================
+ Hits 23235 23245 +10
+ Misses 4394 4393 -1 ☔ View full report in Codecov by Sentry. |
richvdh
requested review from
Hywan and
BillCarsonFr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3810 added a new option to the
CollectStrategyused when collecting recipients for encrypted room keys. We need to expose that to applications via the FFI bindings.Part of https://github.com/element-hq/element-internal/issues/614