indexeddb: fix bugs in serialization improvement #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om_value` Turns out that `serde_wasm_bindgen` isn't happy with some input. Haven't figured out why, yet.
Turns out legacy unencrypted objects can take many forms, and we need to be tolerant of them. Also expose `deserialize_legacy_value` as a separate function, because we're going to need to special-case it.
The name was stupid, and this was the only string that was stored in the legacy format; we can fix both problems with a cheeky migration.
richvdh
force-pushed
the
rav/indexeddb_storage_efficiency_fix_bugs
branch
from
6885c4e
to
98e9abd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3651 +/- ##
==========================================
- Coverage 84.27% 84.25% -0.02%
==========================================
Files 259 259
Lines 26622 26622
==========================================
- Hits 22435 22431 -4
- Misses 4187 4191 +4 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jul 5, 2024
…_efficiency_fix_bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems in #3645, resulting in element-hq/element-web#27666.
JsValue::into_serdeandserde_wasm_bindgen::from_valuedo different things.Apologies for the not-great commits in this PR. I needed to get a release out in a hurry to fix the issue.