-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: Log content of received m.room_key_withheld
messages
#3591
Conversation
Resulting logging looks like:
|
Signed-off-by: Richard van der Hoff <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3591 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 254 254
Lines 26167 26168 +1
=======================================
+ Hits 21936 21937 +1
Misses 4231 4231 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not log contents of every event we receive.
m.room_key_withheld
messages
Co-authored-by: Damir Jelić <[email protected]> Signed-off-by: Richard van der Hoff <[email protected]>
Signed-off-by: Richard van der Hoff <[email protected]>
Signed-off-by: Richard van der Hoff <[email protected]>
Log the content of received
m.room_key_withheld
to-device messages, to fix #3524.Resulting logging looks like:
Original description, now outdated:
This is a first attempt at fixing #3524. Obviously, it solves the reported problem, however there is a concern it might be too spammy.
Otherwise, we might have to be more selective here... maybe only log withheld events?
It shouldn't lead to logging any extra sensitive data - this is all stuff that is shared with the homeserver anyway.