crypto: Storage changes for keeping sender data with InboundGroupSessions #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ready for a first review? |
No, just prototyping for now, thanks! |
andybalaam
force-pushed
the
andybalaam/sender-data-in-igs
branch
from
79afe96 to
03dc672
Compare
andybalaam
changed the title
andybalaam
force-pushed
the
andybalaam/sender-data-in-igs
branch
5 times, most recently
from
cdfa1ad to
73cfc13
Compare
andybalaam
force-pushed
the
andybalaam/sender-data-in-igs
branch
from
73cfc13 to
ae2756b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 255 256 +1
Lines 26345 26366 +21
=======================================
+ Hits 22165 22184 +19
- Misses 4180 4182 +2 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Jun 27, 2024
Co-authored-by: Damir Jelić <[email protected]> Signed-off-by: Andy Balaam <[email protected]>
poljar
approved these changes
Jun 28, 2024
This was referenced Jul 1, 2024
andybalaam
added a commit
that referenced
this pull request
Jul 16, 2024
Part of #3543. Builds on top of #3556 Implements the "fast lane" as described in #3544 This will begin to populate `InboundGroupSession`s with the new `SenderData` struct introduced in #3556 but it will only do it when the information is already available in the store. Future PRs for this issue will query Matrix APIs using spawned async tasks. Future issues will do retries and migration of old sessions. --------- Signed-off-by: Andy Balaam <[email protected]> Co-authored-by: Damir Jelić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3542
This changes the shape of
InboundGroupSessionto allow us to include aSenderDatastruct. To see how it will be populated, look at #3543