Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Rust SDK #141

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Sep 5, 2024

changes:

(matrix-rust-sdk#3846, matrix-rust-sdk#3795, matrix-rust-sdk#2629)
@uhoreg
Copy link
Member Author

uhoreg commented Sep 6, 2024

lots of changes, but should be reviewable commit-by-commit.

@uhoreg uhoreg marked this pull request as ready for review September 6, 2024 01:05
@uhoreg uhoreg requested a review from a team as a code owner September 6, 2024 01:05
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but looks great!


#[wasm_bindgen]
impl CollectStrategy {
/// Tests for equality between two [`CollecStrategy`]s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollecStrategy -> CollectStrategy

@andybalaam andybalaam removed the request for review from BillCarsonFr September 6, 2024 13:16
@uhoreg uhoreg merged commit 5025f00 into matrix-org:main Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants