-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Rust SDK #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
force-pushed
the
update_rust_sdk_20240905
branch
from
September 5, 2024 21:45
5024415
to
87c7671
Compare
(matrix-rust-sdk#3846, matrix-rust-sdk#3795, matrix-rust-sdk#2629)
uhoreg
force-pushed
the
update_rust_sdk_20240905
branch
from
September 6, 2024 00:59
87c7671
to
3e3ace5
Compare
lots of changes, but should be reviewable commit-by-commit. |
andybalaam
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo but looks great!
src/encryption.rs
Outdated
|
||
#[wasm_bindgen] | ||
impl CollectStrategy { | ||
/// Tests for equality between two [`CollecStrategy`]s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CollecStrategy -> CollectStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
ShieldStateCode
(ref: Shields: Add a code field for easier mapping of the state. matrix-rust-sdk#3786)error_on_verified_user_problem
field in device-based strategy (ref: Crypto: Return an error when sharing a room key to a verified user, who has an unverified device (optional encryption setting) matrix-rust-sdk#3810)