-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending encrypted to_device #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
BillCarsonFr
force-pushed
the
valere/send_encrypted_to_device_support
branch
from
February 9, 2024 15:35
90833ef
to
e09ecc3
Compare
BillCarsonFr
force-pushed
the
valere/send_encrypted_to_device_support
branch
from
February 26, 2024 10:59
e09ecc3
to
5e848ab
Compare
richvdh
requested changes
Feb 26, 2024
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
richvdh
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the complicated serialization stuff :/
Hywan
previously requested changes
Mar 11, 2024
…_to_device_support
Co-authored-by: Ivan Enderlin <[email protected]>
…support' into valere/send_encrypted_to_device_support
There's not a lot of point jumping through hoops to turn the json-serialized content back into an object in the Rust layer. Might as well leave it for javascript.
richvdh
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/matrix-rust-sdk#3091
Add bindings to support sending custom encrypted to device event.
see matrix-org/matrix-js-sdk#3304