Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix {enter} press in RTE #9927

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Fix {enter} press in RTE #9927

merged 6 commits into from
Jan 19, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 18, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

The current bug is happening when enter and a modifier key are pressed. The RTE is sending a message when shift/alt/meta/ctrl + enter is pressed instead to send only when enter is pressed (according to ctrlEnterToSend settings).

The fix it's a big ugly but I need to check if only the enter key is pressed.

Here's what your changelog entry will look like:

🐛 Bug Fixes

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 18, 2023
@florianduros florianduros changed the title Fix enter combination in RTE Fix enter in RTE Jan 18, 2023
@florianduros florianduros marked this pull request as ready for review January 18, 2023 09:50
@florianduros florianduros requested a review from a team as a code owner January 18, 2023 09:50
@florianduros florianduros changed the title Fix enter in RTE Fix {enter} press in RTE Jan 18, 2023
dbkr
dbkr reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also some more detail in the PR title could be useful, otherwise the tests are my best guess at what this actually does.

src/components/views/rooms/wysiwyg_composer/hooks/useInputEventProcessor.ts Outdated
? // Ugly but here we need to send the message only if Enter is pressed
// And we need to stop the event propagation on enter to avoid the composer to grow
event.key === "Enter" && !event.shiftKey && !event.ctrlKey && !event.metaKey && !event.altKey
: event.inputType === "insertParagraph");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm, this is making my head hurt somewhat. Use let & some separate if statements to conditionally change it? Or if it must be functional, define isEnterPress as the result of an anonymous function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbkr I added some extra informations in the PR title and I have split the operation in a dedicated function in multiple booleans.

dbkr
dbkr approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - lgtm

@florianduros florianduros enabled auto-merge (squash) January 19, 2023 08:56
@florianduros florianduros merged commit b47588f into develop Jan 19, 2023
@florianduros florianduros deleted the florianduros/fix/new-line-rte branch January 19, 2023 09:17
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Feb 1, 2023
@su-ex
Merge tag 'v3.65.0' into sc
0f9478f 
* Quotes for rte ([\matrix-org#9932](matrix-org#9932)). Contributed by @alunturner.
* Show the room name in the room header during calls ([\matrix-org#9942](matrix-org#9942)). Fixes element-hq/element-web#24268.
* Add code blocks to rich text editor ([\matrix-org#9921](matrix-org#9921)). Contributed by @alunturner.
* Add new style for inline code ([\matrix-org#9936](matrix-org#9936)). Contributed by @florianduros.
* Add disabled button state to rich text editor ([\matrix-org#9930](matrix-org#9930)). Contributed by @alunturner.
* Change the rageshake "app" for auto-rageshakes ([\matrix-org#9909](matrix-org#9909)).
* Device manager - tweak settings display ([\matrix-org#9905](matrix-org#9905)). Contributed by @kerryarchibald.
* Add list functionality to rich text editor ([\matrix-org#9871](matrix-org#9871)). Contributed by @alunturner.
* Fix RTE focus behaviour in threads ([\matrix-org#9969](matrix-org#9969)). Fixes element-hq/element-web#23755. Contributed by @florianduros.
* #22204 Issue: Centered File info in lightbox ([\matrix-org#9971](matrix-org#9971)). Fixes element-hq/element-web#22204. Contributed by @Spartan09.
* Fix seekbar position for zero length audio ([\matrix-org#9949](matrix-org#9949)). Fixes element-hq/element-web#24248.
* Allow thread panel to be closed after being opened from notification ([\matrix-org#9937](matrix-org#9937)). Fixes element-hq/element-web#23764 element-hq/element-web#23852 and element-hq/element-web#24213. Contributed by @justjanne.
* Only highlight focused menu item if focus is supposed to be visible ([\matrix-org#9945](matrix-org#9945)). Fixes element-hq/element-web#23582.
* Prevent call durations from breaking onto multiple lines ([\matrix-org#9944](matrix-org#9944)).
* Tweak call lobby buttons to more closely match designs ([\matrix-org#9943](matrix-org#9943)).
* Do not show a broadcast as live immediately after the recording has stopped ([\matrix-org#9947](matrix-org#9947)). Fixes element-hq/element-web#24233.
* Clear the RTE before sending a message ([\matrix-org#9948](matrix-org#9948)). Contributed by @florianduros.
* Fix {enter} press in RTE ([\matrix-org#9927](matrix-org#9927)). Contributed by @florianduros.
* Fix the problem that the password reset email has to be confirmed twice ([\matrix-org#9926](matrix-org#9926)). Fixes element-hq/element-web#24226.
* replace .at() with array.length-1 ([\matrix-org#9933](matrix-org#9933)). Fixes matrix-org/element-web-rageshakes#19281.
* Fix broken threads list timestamp layout ([\matrix-org#9922](matrix-org#9922)). Fixes element-hq/element-web#24243 and element-hq/element-web#24191. Contributed by @justjanne.
* Disable multiple messages when {enter} is pressed multiple times ([\matrix-org#9929](matrix-org#9929)). Fixes element-hq/element-web#24249. Contributed by @florianduros.
* Fix logout devices when resetting the password ([\matrix-org#9925](matrix-org#9925)). Fixes element-hq/element-web#24228.
* Fix: Poll replies overflow when not enough space ([\matrix-org#9924](matrix-org#9924)). Fixes element-hq/element-web#24227. Contributed by @kerryarchibald.
* State event updates are not forwarded to the widget from invitation room ([\matrix-org#9802](matrix-org#9802)). Contributed by @maheichyk.
* Fix error when viewing source of redacted events ([\matrix-org#9914](matrix-org#9914)). Fixes element-hq/element-web#24165. Contributed by @clarkf.
* Replace outdated css attribute ([\matrix-org#9912](matrix-org#9912)). Fixes element-hq/element-web#24218. Contributed by @justjanne.
* Clear isLogin theme override when user is no longer viewing login screens ([\matrix-org#9911](matrix-org#9911)). Fixes element-hq/element-web#23893.
* Fix reply action in message context menu notif & file panels ([\matrix-org#9895](matrix-org#9895)). Fixes element-hq/element-web#23970.
* Fix issue where thread dropdown would not show up correctly ([\matrix-org#9872](matrix-org#9872)). Fixes element-hq/element-web#24040. Contributed by @justjanne.
* Fix unexpected composer growing ([\matrix-org#9889](matrix-org#9889)). Contributed by @florianduros.
* Fix misaligned timestamps for thread roots which are emotes ([\matrix-org#9875](matrix-org#9875)). Fixes element-hq/element-web#23897. Contributed by @justjanne.
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 19, 2023
@Midar
Update chat/element-web to 1.11.25
5646455 
Changes in [1.11.25](https://github.com/vector-im/element-web/releases/tag/v1.11.25) (2023-03-15)
=================================================================================================

## ✨ Features
 * Remove experimental PWA support for Firefox and Safari ([\#24630](element-hq/element-web#24630)).
 * Only allow to start a DM with one email if encryption by default is enabled ([\#10253](matrix-org/matrix-react-sdk#10253)). Fixes #23133.
 * DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\#10229](matrix-org/matrix-react-sdk#10229)).
 * Reduce bottom margin of ReplyChain on compact modern layout ([\#8972](matrix-org/matrix-react-sdk#8972)). Fixes #22748. Contributed by @luixxiul.
 * Support for v2 of MSC3903 ([\#10165](matrix-org/matrix-react-sdk#10165)). Contributed by @hughns.
 * When starting a DM, existing rooms with pending third-party invites will be reused. ([\#10256](matrix-org/matrix-react-sdk#10256)). Fixes #23139.
 * Polls push rules: synchronise poll rules with message rules ([\#10263](matrix-org/matrix-react-sdk#10263)). Contributed by @kerryarchibald.
 * New verification request toast button labels ([\#10259](matrix-org/matrix-react-sdk#10259)).
 * Remove padding around integration manager iframe ([\#10148](matrix-org/matrix-react-sdk#10148)).
 * Fix block code styling in rich text editor ([\#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
 * Poll history: fetch more poll history ([\#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
 * Sort short/exact emoji matches before longer incomplete matches ([\#10212](matrix-org/matrix-react-sdk#10212)). Fixes #23210. Contributed by @grimhilt.
 * Poll history: detail screen ([\#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
 * Provide a more detailed error message than "No known servers" ([\#6048](matrix-org/matrix-react-sdk#6048)). Fixes #13247. Contributed by @aaronraimist.
 * Say when a call was answered from a different device ([\#10224](matrix-org/matrix-react-sdk#10224)).
 * Widget permissions customizations using module api ([\#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
 * Fix copy button icon overlapping with copyable text ([\#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
 * Support joining non-peekable rooms via the module API ([\#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
 * The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\#10200](matrix-org/matrix-react-sdk#10200)).
 * Do not prompt for a password when doing a „reset all“ after login ([\#10208](matrix-org/matrix-react-sdk#10208)).

## 🐛 Bug Fixes
 * Fix incorrect copy in space creation flow ([\#10296](matrix-org/matrix-react-sdk#10296)). Fixes #24741.
 * Fix space settings dialog having rogue title tooltip ([\#10293](matrix-org/matrix-react-sdk#10293)). Fixes #24740.
 * Show spinner when starting a DM from the user profile (right panel) ([\#10290](matrix-org/matrix-react-sdk#10290)).
 * Reduce height of toggle on expanded view source event ([\#10283](matrix-org/matrix-react-sdk#10283)). Fixes #22873. Contributed by @luixxiul.
 * Pillify http and non-prefixed matrix.to links ([\#10277](matrix-org/matrix-react-sdk#10277)). Fixes #20844.
 * Fix some features not being configurable via `features` ([\#10276](matrix-org/matrix-react-sdk#10276)).
 * Fix starting a DM from the right panel in some cases ([\#10278](matrix-org/matrix-react-sdk#10278)). Fixes #24722.
 * Align info EventTile and normal EventTile on IRC layout ([\#10197](matrix-org/matrix-react-sdk#10197)). Fixes #22782. Contributed by @luixxiul.
 * Fix blowout of waveform of the voice message player on narrow UI ([\#8861](matrix-org/matrix-react-sdk#8861)). Fixes #22604. Contributed by @luixxiul.
 * Fix the hidden view source toggle on IRC layout ([\#10266](matrix-org/matrix-react-sdk#10266)). Fixes #22872. Contributed by @luixxiul.
 * Fix buttons on the room header being compressed due to long room name ([\#10155](matrix-org/matrix-react-sdk#10155)). Contributed by @luixxiul.
 * Use the room avatar as a placeholder in calls ([\#10231](matrix-org/matrix-react-sdk#10231)).
 * Fix calls showing as 'connecting' after hangup ([\#10223](matrix-org/matrix-react-sdk#10223)).
 * Prevent multiple Jitsi calls started at the same time ([\#10183](matrix-org/matrix-react-sdk#10183)). Fixes #23009.
 * Make localization keys compatible with agglutinative and/or SOV type languages ([\#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.

Changes in [1.11.24](https://github.com/vector-im/element-web/releases/tag/v1.11.24) (2023-02-28)
=================================================================================================

## ✨ Features
 * Display "The sender has blocked you from receiving this message" error message instead of "Unable to decrypt message" ([\#10202](matrix-org/matrix-react-sdk#10202)). Contributed by @florianduros.
 * Polls: show warning about undecryptable relations ([\#10179](matrix-org/matrix-react-sdk#10179)). Contributed by @kerryarchibald.
 * Poll history: fetch last 30 days of polls ([\#10157](matrix-org/matrix-react-sdk#10157)). Contributed by @kerryarchibald.
 * Poll history - ended polls list items ([\#10119](matrix-org/matrix-react-sdk#10119)). Contributed by @kerryarchibald.
 * Remove threads labs flag and the ability to disable threads ([\#9878](matrix-org/matrix-react-sdk#9878)). Fixes #24365.
 * Show a success dialog after setting up the key backup ([\#10177](matrix-org/matrix-react-sdk#10177)). Fixes #24487.
 * Release Sign in with QR out of labs ([\#10182](matrix-org/matrix-react-sdk#10182)). Contributed by @hughns.
 * Hide indent button in rte ([\#10149](matrix-org/matrix-react-sdk#10149)). Contributed by @alunturner.
 * Add option to find own location in map views ([\#10083](matrix-org/matrix-react-sdk#10083)).
 * Render poll end events in timeline ([\#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald.

## 🐛 Bug Fixes
 * Stop access token overflowing the box ([\#10069](matrix-org/matrix-react-sdk#10069)). Fixes #24023. Contributed by @sbjaj33.
 * Add link to next file in the export ([\#10190](matrix-org/matrix-react-sdk#10190)). Fixes #20272. Contributed by @grimhilt.
 * Ended poll tiles: add ended the poll message ([\#10193](matrix-org/matrix-react-sdk#10193)). Fixes #24579. Contributed by @kerryarchibald.
 * Fix accidentally inverted condition for room ordering ([\#10178](matrix-org/matrix-react-sdk#10178)). Fixes #24527. Contributed by @justjanne.
 * Re-focus the composer on dialogue quit ([\#10007](matrix-org/matrix-react-sdk#10007)). Fixes #22832. Contributed by @Ashu999.
 * Try to resolve emails before creating a DM ([\#10164](matrix-org/matrix-react-sdk#10164)).
 * Disable poll response loading test ([\#10168](matrix-org/matrix-react-sdk#10168)). Contributed by @justjanne.
 * Fix email lookup in invite dialog ([\#10150](matrix-org/matrix-react-sdk#10150)). Fixes #23353.
 * Remove duplicate white space characters from translation keys ([\#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul.
 * Fix the caption of new sessions manager on Labs settings page for localization ([\#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul.
 * Prevent start another DM with a user if one already exists ([\#10127](matrix-org/matrix-react-sdk#10127)). Fixes #23138.
 * Remove white space characters before the horizontal ellipsis ([\#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul.
 * Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\#10128](matrix-org/matrix-react-sdk#10128)). Fixes #23232. Contributed by @akshattchhabra.
 * Correctly Identify emoticons ([\#10108](matrix-org/matrix-react-sdk#10108)). Fixes #19472. Contributed by @adarsh-sgh.
 * Remove a redundant white space ([\#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.

Changes in [1.11.23](https://github.com/vector-im/element-web/releases/tag/v1.11.23) (2023-02-14)
=================================================================================================

## ✨ Features
 * Description of QR code sign in labs feature ([\#23513](element-hq/element-web#23513)). Contributed by @hughns.
 * Add option to find own location in map views ([\#10083](matrix-org/matrix-react-sdk#10083)).
 * Render poll end events in timeline ([\#10027](matrix-org/matrix-react-sdk#10027)). Contributed by @kerryarchibald.
 * Indicate unread messages in tab title ([\#10096](matrix-org/matrix-react-sdk#10096)). Contributed by @tnt7864.
 * Open message in editing mode when keyboard up is pressed (RTE) ([\#10079](matrix-org/matrix-react-sdk#10079)). Contributed by @florianduros.
 * Hide superseded rooms from the room list using dynamic room predecessors ([\#10068](matrix-org/matrix-react-sdk#10068)). Contributed by @andybalaam.
 * Support MSC3946 in RoomListStore ([\#10054](matrix-org/matrix-react-sdk#10054)). Fixes #24325. Contributed by @andybalaam.
 * Auto focus security key field ([\#10048](matrix-org/matrix-react-sdk#10048)).
 * use Poll model with relations API in poll rendering ([\#9877](matrix-org/matrix-react-sdk#9877)). Contributed by @kerryarchibald.
 * Support MSC3946 in the RoomCreate tile ([\#10041](matrix-org/matrix-react-sdk#10041)). Fixes #24323. Contributed by @andybalaam.
 * Update labs flag description for RTE ([\#10058](matrix-org/matrix-react-sdk#10058)). Contributed by @florianduros.
 * Change ul list style to disc when editing message ([\#10043](matrix-org/matrix-react-sdk#10043)). Contributed by @alunturner.
 * Improved click detection within PiP windows ([\#10040](matrix-org/matrix-react-sdk#10040)). Fixes #24371.
 * Add RTE keyboard navigation in editing ([\#9980](matrix-org/matrix-react-sdk#9980)). Fixes #23621. Contributed by @florianduros.
 * Paragraph integration for rich text editor ([\#10008](matrix-org/matrix-react-sdk#10008)). Contributed by @alunturner.
 * Add  indentation increasing/decreasing to RTE ([\#10034](matrix-org/matrix-react-sdk#10034)). Contributed by @florianduros.
 * Add ignore user confirmation dialog ([\#6116](matrix-org/matrix-react-sdk#6116)). Fixes #14746.
 * Use monospace font for room, message IDs in View Source modal ([\#9956](matrix-org/matrix-react-sdk#9956)). Fixes #21937. Contributed by @paragpoddar.
 * Implement MSC3946 for AdvancedRoomSettingsTab ([\#9995](matrix-org/matrix-react-sdk#9995)). Fixes #24322. Contributed by @andybalaam.
 * Implementation of MSC3824 to make the client OIDC-aware ([\#8681](matrix-org/matrix-react-sdk#8681)). Contributed by @hughns.
 * Improves a11y for avatar uploads ([\#9985](matrix-org/matrix-react-sdk#9985)). Contributed by @GoodGuyMarco.
 * Add support for [token authenticated registration](https ([\#7275](matrix-org/matrix-react-sdk#7275)). Fixes #18931. Contributed by @govynnus.

## 🐛 Bug Fixes
 * Jitsi requests 'requires_client' capability if auth token is provided ([\#24294](element-hq/element-web#24294)). Contributed by @maheichyk.
 * Remove duplicate white space characters from translation keys ([\#10152](matrix-org/matrix-react-sdk#10152)). Contributed by @luixxiul.
 * Fix the caption of new sessions manager on Labs settings page for localization ([\#10143](matrix-org/matrix-react-sdk#10143)). Contributed by @luixxiul.
 * Prevent start another DM with a user if one already exists ([\#10127](matrix-org/matrix-react-sdk#10127)). Fixes #23138.
 * Remove white space characters before the horizontal ellipsis ([\#10130](matrix-org/matrix-react-sdk#10130)). Contributed by @luixxiul.
 * Fix Selectable Text on 'Delete All' and 'Retry All' Buttons ([\#10128](matrix-org/matrix-react-sdk#10128)). Fixes #23232. Contributed by @akshattchhabra.
 * Correctly Identify emoticons ([\#10108](matrix-org/matrix-react-sdk#10108)). Fixes #19472. Contributed by @adarsh-sgh.
 * Should open new 1:1 chat room after leaving the old one ([\#9880](matrix-org/matrix-react-sdk#9880)). Contributed by @ahmadkadri.
 * Remove a redundant white space ([\#10129](matrix-org/matrix-react-sdk#10129)). Contributed by @luixxiul.
 * Fix a crash when removing persistent widgets (updated) ([\#10099](matrix-org/matrix-react-sdk#10099)). Fixes #24412. Contributed by @andybalaam.
 * Fix wrongly grouping 3pid invites into a single repeated transition ([\#10087](matrix-org/matrix-react-sdk#10087)). Fixes #24432.
 * Fix scrollbar colliding with checkbox in add to space section ([\#10093](matrix-org/matrix-react-sdk#10093)). Fixes #23189. Contributed by @Arnabdaz.
 * Add a whitespace character after 'broadcast?' ([\#10097](matrix-org/matrix-react-sdk#10097)). Contributed by @luixxiul.
 * Seekbar in broadcast PiP view is now updated when switching between different broadcasts ([\#10072](matrix-org/matrix-react-sdk#10072)). Fixes #24415.
 * Add border to "reject" button on room preview card for clickable area indication. It fixes element-hq/element-web#22623 ([\#9205](matrix-org/matrix-react-sdk#9205)). Contributed by @gefgu.
 * Element-R: fix rageshages ([\#10081](matrix-org/matrix-react-sdk#10081)). Fixes #24430.
 * Fix markdown paragraph display in timeline ([\#10071](matrix-org/matrix-react-sdk#10071)). Fixes #24419. Contributed by @alunturner.
 * Prevent the remaining broadcast time from being exceeded ([\#10070](matrix-org/matrix-react-sdk#10070)).
 * Fix cursor position when new line is created by pressing enter (RTE) ([\#10064](matrix-org/matrix-react-sdk#10064)). Contributed by @florianduros.
 * Ensure room is actually in space hierarchy when resolving its latest version ([\#10010](matrix-org/matrix-react-sdk#10010)).
 * Fix new line for inline code ([\#10062](matrix-org/matrix-react-sdk#10062)). Contributed by @florianduros.
 * Member avatars without canvas ([\#9990](matrix-org/matrix-react-sdk#9990)). Contributed by @clarkf.
 * Apply more general fix for base avatar regressions ([\#10045](matrix-org/matrix-react-sdk#10045)). Fixes #24382 and #24370.
 * Replace list, code block and quote icons by new icons ([\#10035](matrix-org/matrix-react-sdk#10035)). Contributed by @florianduros.
 * fix regional emojis converted to flags ([\#9294](matrix-org/matrix-react-sdk#9294)). Fixes #19000. Contributed by @grimhilt.
 * resolved emoji description text overflowing issue ([\#10028](matrix-org/matrix-react-sdk#10028)). Contributed by @fahadNoufal.
 * Fix MessageEditHistoryDialog crashing on complex input ([\#10018](matrix-org/matrix-react-sdk#10018)). Fixes #23665. Contributed by @clarkf.
 * Unify unread notification state determination ([\#9941](matrix-org/matrix-react-sdk#9941)). Contributed by @clarkf.
 * Fix layout and visual regressions around default avatars ([\#10031](matrix-org/matrix-react-sdk#10031)). Fixes #24375 and #24369.
 * Fix useUnreadNotifications exploding with falsey room, like in notif panel ([\#10030](matrix-org/matrix-react-sdk#10030)). Fixes matrix-org/element-web-rageshakes#19334.
 * Fix "[object Promise]" appearing in HTML exports ([\#9975](matrix-org/matrix-react-sdk#9975)). Fixes #24272. Contributed by @clarkf.
 * changing the color of message time stamp ([\#10016](matrix-org/matrix-react-sdk#10016)). Contributed by @nawarajshah.
 * Fix link creation with backward selection ([\#9986](matrix-org/matrix-react-sdk#9986)). Fixes #24315. Contributed by @florianduros.
 * Misaligned reply preview in thread composer #23396 ([\#9977](matrix-org/matrix-react-sdk#9977)). Fixes #23396. Contributed by @mustafa-kapadia1483.

Changes in [1.11.22](https://github.com/vector-im/element-web/releases/tag/v1.11.22) (2023-01-31)
=================================================================================================

## 🐛 Bug Fixes
 * Bump version number to fix problems upgrading from v1.11.21-rc.1

Changes in [1.11.21](https://github.com/vector-im/element-web/releases/tag/v1.11.21) (2023-01-31)
=================================================================================================

## ✨ Features
 * Move pin drop out of labs ([\#22993](element-hq/element-web#22993)).
 * Quotes for rich text editor (RTE) ([\#9932](matrix-org/matrix-react-sdk#9932)). Contributed by @alunturner.
 * Show the room name in the room header during calls ([\#9942](matrix-org/matrix-react-sdk#9942)). Fixes #24268.
 * Add code blocks to rich text editor ([\#9921](matrix-org/matrix-react-sdk#9921)). Contributed by @alunturner.
 * Add new style for inline code ([\#9936](matrix-org/matrix-react-sdk#9936)). Contributed by @florianduros.
 * Add disabled button state to rich text editor ([\#9930](matrix-org/matrix-react-sdk#9930)). Contributed by @alunturner.
 * Change the rageshake "app" for auto-rageshakes ([\#9909](matrix-org/matrix-react-sdk#9909)).
 * Device manager - tweak settings display ([\#9905](matrix-org/matrix-react-sdk#9905)). Contributed by @kerryarchibald.
 * Add list functionality to rich text editor ([\#9871](matrix-org/matrix-react-sdk#9871)). Contributed by @alunturner.

## 🐛 Bug Fixes
 * Fix RTE focus behaviour in threads ([\#9969](matrix-org/matrix-react-sdk#9969)). Fixes #23755. Contributed by @florianduros.
 * #22204 Issue: Centered File info in lightbox ([\#9971](matrix-org/matrix-react-sdk#9971)). Fixes #22204. Contributed by @Spartan09.
 * Fix seekbar position for zero length audio ([\#9949](matrix-org/matrix-react-sdk#9949)). Fixes #24248.
 * Allow thread panel to be closed after being opened from notification ([\#9937](matrix-org/matrix-react-sdk#9937)). Fixes #23764 #23852 and #24213. Contributed by @justjanne.
 * Only highlight focused menu item if focus is supposed to be visible ([\#9945](matrix-org/matrix-react-sdk#9945)). Fixes #23582.
 * Prevent call durations from breaking onto multiple lines ([\#9944](matrix-org/matrix-react-sdk#9944)).
 * Tweak call lobby buttons to more closely match designs ([\#9943](matrix-org/matrix-react-sdk#9943)).
 * Do not show a broadcast as live immediately after the recording has stopped ([\#9947](matrix-org/matrix-react-sdk#9947)). Fixes #24233.
 * Clear the RTE before sending a message ([\#9948](matrix-org/matrix-react-sdk#9948)). Contributed by @florianduros.
 * Fix {enter} press in RTE ([\#9927](matrix-org/matrix-react-sdk#9927)). Contributed by @florianduros.
 * Fix the problem that the password reset email has to be confirmed twice ([\#9926](matrix-org/matrix-react-sdk#9926)). Fixes #24226.
 * replace .at() with array.length-1 ([\#9933](matrix-org/matrix-react-sdk#9933)). Fixes matrix-org/element-web-rageshakes#19281.
 * Fix broken threads list timestamp layout ([\#9922](matrix-org/matrix-react-sdk#9922)). Fixes #24243 and #24191. Contributed by @justjanne.
 * Disable multiple messages when {enter} is pressed multiple times ([\#9929](matrix-org/matrix-react-sdk#9929)). Fixes #24249. Contributed by @florianduros.
 * Fix logout devices when resetting the password ([\#9925](matrix-org/matrix-react-sdk#9925)). Fixes #24228.
 * Fix: Poll replies overflow when not enough space ([\#9924](matrix-org/matrix-react-sdk#9924)). Fixes #24227. Contributed by @kerryarchibald.
 * State event updates are not forwarded to the widget from invitation room ([\#9802](matrix-org/matrix-react-sdk#9802)). Contributed by @maheichyk.
 * Fix error when viewing source of redacted events ([\#9914](matrix-org/matrix-react-sdk#9914)). Fixes #24165. Contributed by @clarkf.
 * Replace outdated css attribute ([\#9912](matrix-org/matrix-react-sdk#9912)). Fixes #24218. Contributed by @justjanne.
 * Clear isLogin theme override when user is no longer viewing login screens ([\#9911](matrix-org/matrix-react-sdk#9911)). Fixes #23893.
 * Fix reply action in message context menu notif & file panels ([\#9895](matrix-org/matrix-react-sdk#9895)). Fixes #23970.
 * Fix issue where thread dropdown would not show up correctly ([\#9872](matrix-org/matrix-react-sdk#9872)). Fixes #24040. Contributed by @justjanne.
 * Fix unexpected composer growing ([\#9889](matrix-org/matrix-react-sdk#9889)). Contributed by @florianduros.
 * Fix misaligned timestamps for thread roots which are emotes ([\#9875](matrix-org/matrix-react-sdk#9875)). Fixes #23897. Contributed by @justjanne.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr