Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add prettier #9735

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Add prettier #9735

merged 4 commits into from
Dec 12, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Dec 12, 2022 •
edited
Loading

Best to be reviewed commitwise

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Percy labels Dec 12, 2022
andybalaam
andybalaam approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when you're ready.

Thank you!

@weeman1337
Copy link
Contributor Author

weeman1337 commented Dec 12, 2022 •
edited
Loading

  • percy/matrix-react-sdk the usual 1px off
  • Static Analysis / Typescript Strict Error Checker (--strict --noImplicitAny) (pull_request) failing because of too many files in the changeset
  • SonarCloud Code Analysis complains about < 80 % coverage + some legacy code spots
  • Did look at some random files in the changeset ✔️
  • Smoke tested the deployment ✔️

go @andybalaam

@weeman1337 weeman1337 marked this pull request as ready for review December 12, 2022 12:25
@weeman1337 weeman1337 requested review from a team as code owners December 12, 2022 12:25
@andybalaam andybalaam merged commit d835721 into develop Dec 12, 2022
@andybalaam andybalaam deleted the weeman1337/prettier branch December 12, 2022 17:15
@richvdh richvdh mentioned this pull request Dec 14, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-team

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @andybalaam