Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update Voice Broadcast buffering style #9643

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 29, 2022

Part of element-hq/element-web#23282

The new buffering style allows pausing while buffering.

Before

buffering_before

After

buffering_after

PSF-1764

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 29, 2022
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, one small question :)

@weeman1337 weeman1337 merged commit d0fd0cf into develop Nov 30, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-new-buffering branch November 30, 2022 10:43
@weeman1337 weeman1337 added the backport staging Label to automatically backport PR to staging branch label Nov 30, 2022
RiotRobot pushed a commit that referenced this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport staging Label to automatically backport PR to staging branch T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants