This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 832
Update Voice Broadcast buffering style #9643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Nov 29, 2022
weeman1337
force-pushed
the
weeman1337/voice-broadcast-new-buffering
branch
from
November 29, 2022 09:33
3504fe4
to
c2eac6c
Compare
florianduros
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM, one small question :)
weeman1337
added
the
backport staging
Label to automatically backport PR to staging branch
label
Nov 30, 2022
RiotRobot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit d0fd0cf)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport staging
Label to automatically backport PR to staging branch
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#23282
The new buffering style allows pausing while buffering.
Before
After
PSF-1764
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.