Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add voice broadcast playback pip #9603

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 21, 2022

Part of element-hq/element-web#23282

PSF-1632

https://www.figma.com/file/5zlCPsSOJELBzIiQdHC2LV/Voice-Broadcasting?node-id=11%3A4052&t=FEXBzGswLy9dHaMo-0

image

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 21, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-playback-pip branch from b3a11e1 to 5571892 Compare November 21, 2022 10:29
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-playback-pip branch from 5571892 to 7fbe8a9 Compare November 21, 2022 13:45
@weeman1337 weeman1337 changed the base branch from develop to weeman1337/refactor-pip-view November 21, 2022 13:46
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-playback-pip branch from 7fbe8a9 to 5ed7ce4 Compare November 21, 2022 17:09
Base automatically changed from weeman1337/refactor-pip-view to develop November 22, 2022 06:57
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-playback-pip branch 2 times, most recently from 55fae6d to abe9fbe Compare November 22, 2022 09:36
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-playback-pip branch from abe9fbe to 78dacd3 Compare November 22, 2022 10:13
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like the contact types might need tweaking

@weeman1337 weeman1337 merged commit a8e15eb into develop Nov 24, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-playback-pip branch November 24, 2022 08:08
amywalkerdev pushed a commit that referenced this pull request Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants